BottomNavigationItem: API scrub [161809324]

Fixed

Bug

Status Update

No update yet.

Description

ma...@google.com

created issue #1

Jul 21, 2020 05:44PM

API scrub feedback for BottomNavigationItem:

rename text to label to match alwaysShowLabel param
onSelected -> onSelect

Comments

ma...@google.com <ma...@google.com> Jul 24, 2020 11:16AM

Reassigned to lp...@google.com.

ap...@google.com <ap...@google.com> #2Jul 28, 2020 02:05PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020

IconButton / IconToggleButton API scrub

Test: ./gradlew updateApi
Bug:

b/161809385

Bug:

b/161807956

Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96

M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt

https://android-review.googlesource.com/1394868

lp...@google.com <lp...@google.com> Jul 28, 2020 02:14PM

Marked as fixed.

lp...@google.com <lp...@google.com> #3Sep 9, 2020 04:04PM

Status: Assigned (reopened)

Discussed further offline, onSelect should be renamed to onClick for consistency (with Tab and other components).

ap...@google.com <ap...@google.com> #4Sep 9, 2020 06:38PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit dfd1e72afa17243e42449e955f08213f0a4afcd4
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Wed Sep 09 17:04:47 2020

Renames BottomNavigationItem's onSelect parameter to onClick for consistency with other components such as Tab

Bug:

b/161809324

Test: ./gradlew updateApi
Relnote: "Renames BottomNavigationItem's onSelect parameter to onClick"
Change-Id: I919251069ab307d1ed5c1c3fbf5a01bf77a85047

M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/samples/src/main/java/androidx/compose/material/samples/BottomNavigationSamples.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationScreenshotTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomNavigation.kt

https://android-review.googlesource.com/1423472

lp...@google.com <lp...@google.com> Sep 9, 2020 09:54PM