Fixed
Status Update
Comments
ma...@google.com <ma...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit ee202eaf0657ee1f7182d1776a8cb3a2ac9792cf
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Thu Jul 30 17:41:03 2020
Adds TabConstants object, removes TabRow object, other TabRow polishing
Default values / implementations used by Tab and TabRow now exist in TabConstants, consistent with Buttons and other components. TabPosition has been moved to a top level class, other members of TabRow have moved to TabConstants.
Additionally updates IndicatorContainer() to just be a modifier that can be applied to an indicator, and renames `indicatorContainer` to `indicator` accordingly.
Bug: b/161809544
Test: TabTest
Relnote: "The `TabRow` object has been removed, replacing it with TabConstants. TabRow.TabPosition has moved to be top level (TabPosition), and indicatorContainer has been renamed to `indicator`. See the samples and documentation for detailed information on how to use the updated API, and defaults."
Change-Id: I54d452697a70b9653812e5366420563a3aa19209
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/TabSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/TabTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/Tab.kt
https://android-review.googlesource.com/1380736
Branch: androidx-master-dev
commit ee202eaf0657ee1f7182d1776a8cb3a2ac9792cf
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Thu Jul 30 17:41:03 2020
Adds TabConstants object, removes TabRow object, other TabRow polishing
Default values / implementations used by Tab and TabRow now exist in TabConstants, consistent with Buttons and other components. TabPosition has been moved to a top level class, other members of TabRow have moved to TabConstants.
Additionally updates IndicatorContainer() to just be a modifier that can be applied to an indicator, and renames `indicatorContainer` to `indicator` accordingly.
Bug:
Test: TabTest
Relnote: "The `TabRow` object has been removed, replacing it with TabConstants. TabRow.TabPosition has moved to be top level (TabPosition), and indicatorContainer has been renamed to `indicator`. See the samples and documentation for detailed information on how to use the updated API, and defaults."
Change-Id: I54d452697a70b9653812e5366420563a3aa19209
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/TabSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/TabTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/Tab.kt
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit eb7b38fad291ab63daa4ae5409f473248c803d17
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Thu Jul 30 19:59:57 2020
Splits TabRow into TabRow and ScrollableTabRow
Removes the isScrollable parameter from TabRow, and exposes edgePadding in ScrollableTabRow.
Bug: b/161809544
Test: TabTest
Relnote: "Splits TabRow into TabRow and ScrollableTabRow, removing isScrollable from TabRow. Also exposes edgePadding in ScrollableTabRow, which allows controlling the free space before / after the tabs."
Change-Id: I583e82f0424571b538adbf6f3e8f69721c37352b
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/TabSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/TabTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/Tab.kt
A ui/ui-material/src/commonMain/kotlin/androidx/compose/material/TabRow.kt
https://android-review.googlesource.com/1380158
Branch: androidx-master-dev
commit eb7b38fad291ab63daa4ae5409f473248c803d17
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Thu Jul 30 19:59:57 2020
Splits TabRow into TabRow and ScrollableTabRow
Removes the isScrollable parameter from TabRow, and exposes edgePadding in ScrollableTabRow.
Bug:
Test: TabTest
Relnote: "Splits TabRow into TabRow and ScrollableTabRow, removing isScrollable from TabRow. Also exposes edgePadding in ScrollableTabRow, which allows controlling the free space before / after the tabs."
Change-Id: I583e82f0424571b538adbf6f3e8f69721c37352b
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/TabSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/TabTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/Tab.kt
A ui/ui-material/src/commonMain/kotlin/androidx/compose/material/TabRow.kt
Description
API scrub feedback for TabRow:
BottomNavigation
(removeitems
in params, etc)ScrollableTabRow
andTabRow
IndicationContainer
- think about moving to modifiers to just renameTabRowConstants
TabRowConstants
TabPositions
instead of list<TabRow.TabPosition> - mark @Immutable