Fixed
Status Update
Comments
ma...@google.com <ma...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug: b/161809385
Bug: b/161807956
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
https://android-review.googlesource.com/1394868
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug:
Bug:
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit eb7b38fad291ab63daa4ae5409f473248c803d17
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Thu Jul 30 19:59:57 2020
Splits TabRow into TabRow and ScrollableTabRow
Removes the isScrollable parameter from TabRow, and exposes edgePadding in ScrollableTabRow.
Bug: b/161809544
Test: TabTest
Relnote: "Splits TabRow into TabRow and ScrollableTabRow, removing isScrollable from TabRow. Also exposes edgePadding in ScrollableTabRow, which allows controlling the free space before / after the tabs."
Change-Id: I583e82f0424571b538adbf6f3e8f69721c37352b
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/TabSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/TabTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/Tab.kt
A ui/ui-material/src/commonMain/kotlin/androidx/compose/material/TabRow.kt
https://android-review.googlesource.com/1380158
Branch: androidx-master-dev
commit eb7b38fad291ab63daa4ae5409f473248c803d17
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Thu Jul 30 19:59:57 2020
Splits TabRow into TabRow and ScrollableTabRow
Removes the isScrollable parameter from TabRow, and exposes edgePadding in ScrollableTabRow.
Bug:
Test: TabTest
Relnote: "Splits TabRow into TabRow and ScrollableTabRow, removing isScrollable from TabRow. Also exposes edgePadding in ScrollableTabRow, which allows controlling the free space before / after the tabs."
Change-Id: I583e82f0424571b538adbf6f3e8f69721c37352b
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/TabSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/TabTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/Tab.kt
A ui/ui-material/src/commonMain/kotlin/androidx/compose/material/TabRow.kt
Description
API scrub feedback for TabRow:
BottomNavigation
(removeitems
in params, etc)ScrollableTabRow
andTabRow
IndicationContainer
- think about moving to modifiers to just renameTabRowConstants
TabRowConstants
TabPositions
instead of list<TabRow.TabPosition> - mark @Immutable