Failing androidx.benchmark.BenchmarkStateTest#priorityJitThread on API 23 [161847393]

Fixed

Bug

Status Update

No update yet.

Description

au...@google.com

created issue #1

Jul 22, 2020 12:27AM

java.lang.IllegalStateException: Jit thread not found!
	at androidx.benchmark.ThreadPriority.getJit(ThreadPriority.kt:153)
	at androidx.benchmark.BenchmarkStateTest.priorityJitThread(BenchmarkStateTest.kt:114)
	at java.lang.reflect.Method.invoke(Native Method)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at androidx.test.rule.GrantPermissionRule$RequestPermissionStatement.evaluate(GrantPermissionRule.java:134)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
	at androidx.test.internal.runner.TestExecutor.execute(TestExecutor.java:56)
	at androidx.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:395)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)

https://android-build.googleplex.com/builds/tests/view?invocationId=I81700005121340745&redirect=http%3A%2F%2Fsponge.corp.google.com%2Ftarget%3Fshow%3DFAILED%26sortBy%3DSTATUS%26id%3D0b9289cf-ff3d-4926-8717-347991eb03f3%26target%3Dandroidx.benchmark.test&testClass=BenchmarkStateTest&testMethod=priorityJitThread&testPackage=androidx.benchmark

Comments

au...@google.com <au...@google.com> #2Jul 29, 2020 05:14PM

It seems that it fails on API 21 as well https://android-build.googleplex.com/builds/tests/view?invocationId=I27400005416207821&testResultId=TR81211112316239459

cc...@google.com <cc...@google.com> #3Jul 29, 2020 05:50PM

Accepted by cc...@google.com.

Not sure why that behavior turns on with 21, I think it should be 24, since that's N. Will fix.

From logcat, threads in process are below - no obvious JIT thread.

01-29 03:58:02.285 30260 30273 D Benchmark: tid: 30260, name:'.benchmark.test' 01-29 03:58:02.285 30260 30273 D Benchmark: tid: 30265, name:'Signal Catcher' 01-29 03:58:02.285 30260 30273 D Benchmark: tid: 30266, name:'JDWP' 01-29 03:58:02.285 30260 30273 D Benchmark: tid: 30267, name:'ReferenceQueueD' 01-29 03:58:02.285 30260 30273 D Benchmark: tid: 30268, name:'FinalizerDaemon' 01-29 03:58:02.285 30260 30273 D Benchmark: tid: 30269, name:'FinalizerWatchd' 01-29 03:58:02.285 30260 30273 D Benchmark: tid: 30270, name:'HeapTaskDaemon' 01-29 03:58:02.285 30260 30273 D Benchmark: tid: 30271, name:'Binder_1' 01-29 03:58:02.285 30260 30273 D Benchmark: tid: 30272, name:'Binder_2' 01-29 03:58:02.285 30260 30273 D Benchmark: tid: 30273, name:'roidJUnitRunner' 01-29 03:58:02.285 30260 30273 D Benchmark: tid: 30274, name:'Instrumentation'

cc...@google.com <cc...@google.com> #4Jul 29, 2020 05:51PM

(whoops, forgot markdown)

01-29 03:58:02.285 30260 30273 D Benchmark: NOTE: Couldn't JIT thread, threads found:
01-29 03:58:02.285 30260 30273 D Benchmark:     tid: 30260, name:'.benchmark.test'
01-29 03:58:02.285 30260 30273 D Benchmark:     tid: 30265, name:'Signal Catcher'
01-29 03:58:02.285 30260 30273 D Benchmark:     tid: 30266, name:'JDWP'
01-29 03:58:02.285 30260 30273 D Benchmark:     tid: 30267, name:'ReferenceQueueD'
01-29 03:58:02.285 30260 30273 D Benchmark:     tid: 30268, name:'FinalizerDaemon'
01-29 03:58:02.285 30260 30273 D Benchmark:     tid: 30269, name:'FinalizerWatchd'
01-29 03:58:02.285 30260 30273 D Benchmark:     tid: 30270, name:'HeapTaskDaemon'
01-29 03:58:02.285 30260 30273 D Benchmark:     tid: 30271, name:'Binder_1'
01-29 03:58:02.285 30260 30273 D Benchmark:     tid: 30272, name:'Binder_2'
01-29 03:58:02.285 30260 30273 D Benchmark:     tid: 30273, name:'roidJUnitRunner'
01-29 03:58:02.285 30260 30273 D Benchmark:     tid: 30274, name:'Instrumentation'

ap...@google.com <ap...@google.com> #5Jul 30, 2020 03:41PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b5538a603e88609a7d6290daea884559992d52e8
Author: Chris Craik <ccraik@google.com>
Date: Wed Jul 29 10:54:07 2020

Fix JIT thread detection to start on N

Fixes: 161847393
Relnote: """Fixes library printing logcat warnings about not finding
JIT thread on platform versions where it is not present."""
Test: ./gradlew bench:b-c:cC # note, relying on postsubmit for lower api levels

Change-Id: I9cc637ed3d5ec50169f4bad795d47c4f2a03befa

M benchmark/common/src/androidTest/java/androidx/benchmark/BenchmarkStateTest.kt
M benchmark/common/src/main/java/androidx/benchmark/ThreadPriority.kt

https://android-review.googlesource.com/1377803

Issue 161847393

Description

Issue summary

Comments

au...@google.com <au...@google.com> #2Jul 29, 2020 05:14PM

cc...@google.com <cc...@google.com> #3Jul 29, 2020 05:50PM

cc...@google.com <cc...@google.com> #4Jul 29, 2020 05:51PM

ap...@google.com <ap...@google.com> #5Jul 30, 2020 03:41PM

Add comment

Issue metadata