Semantics not being merged in dev15 [161979921]

Fixed

Bug

Status Update

No update yet.

Description

ja...@google.com

created issue #1

Jul 23, 2020 03:15PM

In dev15, some tests are broken in Jetnews as a result of semantics not being merged anymore.

For example Box(Modifier.clickable) { Text("This text does not appear on the tree") }

The workaround is to useUnmergedTree = true

@Test
fun app_opensArticle() {
onRoot(useUnmergedTree = true).printToLog("jetnews")
onAllNodes(hasSubstring("Manuel Vivo"), useUnmergedTree = true)[0].performClick()
onAllNodes(hasSubstring("3 min read"), useUnmergedTree = true)[0].assertIsDisplayed()
}

Filip believes the regression happened in aosp/1360099

Comments

pa...@google.com <pa...@google.com> #2Jul 23, 2020 03:43PM

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

ae...@google.com <ae...@google.com> Jul 23, 2020 08:42PM

Accepted by ae...@google.com.

ae...@google.com <ae...@google.com> #3Jul 27, 2020 08:34PM

Thanks for the report!

ae...@google.com <ae...@google.com> #4Jul 29, 2020 07:19AM

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

ap...@google.com <ap...@google.com> #5Aug 11, 2020 11:23PM

Marked as fixed.

deleted

Issue 161979921