Mix of improvements and regressions in draw [162061312]

Fixed

Bug

Status Update

No update yet.

Description

pa...@google.com

created issue #1

Jul 24, 2020 01:24PM

Alert on dashboard: https://androidx-perf.skia.org/t/?begin=1595016806&end=1595016807&subset=all

CLs in build: https://android-master-ingest.skia.org/r/6689866?branch=aosp-androidx-master-dev

Suspected CL: aosp/1362976

Improvements:

androidx.ui.benchmark.test.CheckboxesInRowsBenchmark_toggleCheckbox_draw_10_
androidx.ui.benchmark.test.RadioGroupBenchmark_toggleRadio_draw
androidx.ui.benchmark.test.CheckboxesInRowsBenchmark_toggleCheckbox_draw_1_

Regressions:

androidx.ui.benchmark.test.TextInColumnBenchmark_first_draw_100_
androidx.ui.benchmark.test.TextInColumnBenchmark_toggleRectangleColor_draw_100_

Layout regression:

androidx.ui.benchmark.test.TextInColumnBenchmark_layout_100_
(maybe due to the added modifier)

Comments

mo...@google.com <mo...@google.com> #2Jul 24, 2020 04:10PM

Putting this into scaffold makes it work. See b/268432129 with another issue (scaffold is there).

pa...@google.com <pa...@google.com> #3Jul 24, 2020 08:47PM

Project: platform/frameworks/support
Branch: androidx-main

commit 46eea23c96f45f0ee1e57d8aef2f1375507b0dec
Author: José Figueroa Santos <serniebanders@google.com>
Date: Tue Apr 11 14:38:58 2023

[M3][ModalBottomSheet] Enable edge to edge functionality for ModalBottomSheet

Bug: 274872542
Bug: 272973615
Bug: 272334475
Bug: 268432129
Bug: 275849044
Bug: 275486106
Bug: 268433162
RelNote: Add window insets parameter to ModalBottomSheet.
RelNote: Scrim for ModalBottomSheet may now be drawn behind status bar with windowInsets set to zero
RelNote: Updated default ModalBottomSheet functionality to stay outside of system bars including navigation
RelNote: Status bar inset handling is provided by drag handle in edge-to-edge mode.
RelNote: BottomSheetDefaults includes window insets for BottomSheetWindow.
Test: Parameterizes existing tests to work with and without edgeToEdge enabled.
Test: Manual EdgeToEdge testing on various devices and android APIs
Change-Id: I312008e48573ebd21326f77216be0bcd0372aa78

M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/BottomSheetSamples.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/Strings.android.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SheetDefaults.kt

https://android-review.googlesource.com/2531428

jl...@google.com <jl...@google.com> #4Jul 24, 2020 09:28PM

New windows drawn by AbstractComposeView such as popups, dialogs, and ModalBottomSheet do not inherit insets provided when fitSystemWindows=false. The following change once landed provides a windowInsets param which can be set to 0 to provide an edge-to-edge experience, or other windowInsetPaddings.

jl...@google.com <jl...@google.com> #5Jul 24, 2020 09:28PM

Reassigned to mo...@google.com.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.2.0-alpha02
androidx.compose.material3:material3-android:1.2.0-alpha02

nj...@google.com <nj...@google.com> #6Jul 25, 2020 07:23AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.1.1

mo...@google.com <mo...@google.com> #7Jul 27, 2020 11:16PM

We might be able to improve the performance of this by reusing layers.

pa...@google.com <pa...@google.com> #8Jul 28, 2020 10:59AM

I agree with you Nader that we definitely care more about "frequent" updates rather than one time cases (unless we start considering cases like recycler view). But I just file a bug for any performance change and let the owners to decide on the strategy as I don't have enough context to make the call.

mo...@google.com <mo...@google.com> #9Aug 27, 2020 09:47PM

I tried caching layers (per AndroidComposeView) and am not able to significantly affect the performance. I think the performance problems may be due to reflection calls in the View implementation. I will experiment with this.

ap...@google.com <ap...@google.com> #10Sep 2, 2020 05:31PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 47330e9a6400a0ea10e6ef007661ae14523fa529
Author: George Mount <mount@google.com>
Date: Tue Sep 01 11:00:24 2020

Move layer creation to attach point.

Layers should not be created during layout and draw, but instead
in less time-critical part of the operation. This moves layer
creation to the commit time, when the modifier is attached.

Relnote: "Removed onInvalidate() from Owner -- OwnedLayer
handles invalidation."

Fixes: 162061312

Test: ui connectedCheck
Test: TextInColumnBenchmark#layout
Change-Id: Ica72b49b10b5f2bd25845cb6c9fc45f085b679e7

M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/PointerInputEventProcessorTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidViewsHandler.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/DelegatingLayoutNodeWrapper.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayerWrapper.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNodeWrapper.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/Owner.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopOwner.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/node/LayoutNodeTest.kt

https://android-review.googlesource.com/1417428

ap...@google.com <ap...@google.com> #11Sep 2, 2020 07:35PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b727b3532cc88187ff73ee6d14ecf9d884bb1b04
Author: George Mount <mount@google.com>
Date: Fri Aug 28 08:57:00 2020

Support RenderNode on M-O devices.

Bug: 162061312

To avoid reflection, a new stub library was created to
support RenderNode on older devices. This should also improve
allocation performance as RenderNodes should be much smaller
and easier to allocate than Views.

This does not currently work on P devices because ART
does not allow access to APIs in the unsupported list on P.

TextInColumnBenchmark#first_draw is around 30% faster in
my local tests.

This CL will make benchmark performance slower on M-O devices,
but it is more representative of actual performance. It turns
out that PictureRecordingCanvas has faster access than
DisplayListCanvas and was giving artificially fast results
on devices that don't support hardware accelerated canvas.

Test: demo on API 23, 26, 29
Test: TextInColumnBenchmark#first_draw
Test: New test for fallback for M RenderNode to View

Change-Id: Ia10caea550f328368c4f0f4384267058d1dbc541

M compose/test-utils/build.gradle
M compose/test-utils/src/androidMain/kotlin/androidx/compose/testutils/AndroidComposeTestCaseRunner.kt
A compose/ui/ui-android-stubs/build.gradle
A compose/ui/ui-android-stubs/src/main/AndroidManifest.xml
A compose/ui/ui-android-stubs/src/main/java/android/view/DisplayListCanvas.java
A compose/ui/ui-android-stubs/src/main/java/android/view/RenderNode.java
M compose/ui/ui/build.gradle
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/AndroidLayoutDrawTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.kt
A compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/DeviceRenderNode.kt
A compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeApi23.kt
A compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeApi29.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeLayer.kt
M ui/settings.gradle

https://android-review.googlesource.com/1414989