Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 9082f62682f853ad5251a1c79dde9eccba7abdd9
Author: Max Alfonso-Ying <maxying@google.com>
Date: Thu Apr 18 00:34:40 2024
[M2 text field] Apply background to decoration box
...instead of to the BasicTextField, so changing the
backgroundColor will properly change the decoration
box's background color.
Fixes: b/307694651
Test: added unit tests
Relnote: "Fix backgroundColor not applying to
TextFieldDecorationBox and OutlinedTextFieldDecorationBox.
Decoration boxes now accept a `shape` parameter."
Change-Id: I371c26718597cb36ac537e9412ce476532afb40d
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/TextFieldDecorationBoxDemos.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/textfield/TextFieldDecorationBoxTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldDefaults.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt
https://android-review.googlesource.com/3046833
Branch: androidx-main
commit 9082f62682f853ad5251a1c79dde9eccba7abdd9
Author: Max Alfonso-Ying <maxying@google.com>
Date: Thu Apr 18 00:34:40 2024
[M2 text field] Apply background to decoration box
...instead of to the BasicTextField, so changing the
backgroundColor will properly change the decoration
box's background color.
Fixes:
Test: added unit tests
Relnote: "Fix backgroundColor not applying to
TextFieldDecorationBox and OutlinedTextFieldDecorationBox.
Decoration boxes now accept a `shape` parameter."
Change-Id: I371c26718597cb36ac537e9412ce476532afb40d
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/TextFieldDecorationBoxDemos.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/textfield/TextFieldDecorationBoxTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldDefaults.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 69d3bebae09336724c1bb77dd2c95d4af61dfe41
Author: George Mount <mount@google.com>
Date: Wed Aug 12 13:26:53 2020
Remove OnChildPositionedModifier
Relnote: "Removed onChildPositioned and OnChildPositionedModifier.
Developers should use onPositioned and OnPositionedModifier
on the child layout instead."
Bug: 162109766
Test: changed tests.
Change-Id: I4522e2cd4a0edb08fd36212eacf19d2895ae87f7
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/compose/ui/layout/OnPositionedTest.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/OnPositionedModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
M ui/ui-layout/src/androidAndroidTest/kotlin/androidx/compose/foundation/layout/IntrinsicTest.kt
M ui/ui-layout/src/androidAndroidTest/kotlin/androidx/compose/foundation/layout/OnPositionedTest.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/ButtonTest.kt
https://android-review.googlesource.com/1398645
Branch: androidx-master-dev
commit 69d3bebae09336724c1bb77dd2c95d4af61dfe41
Author: George Mount <mount@google.com>
Date: Wed Aug 12 13:26:53 2020
Remove OnChildPositionedModifier
Relnote: "Removed onChildPositioned and OnChildPositionedModifier.
Developers should use onPositioned and OnPositionedModifier
on the child layout instead."
Bug: 162109766
Test: changed tests.
Change-Id: I4522e2cd4a0edb08fd36212eacf19d2895ae87f7
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/compose/ui/layout/OnPositionedTest.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/OnPositionedModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
M ui/ui-layout/src/androidAndroidTest/kotlin/androidx/compose/foundation/layout/IntrinsicTest.kt
M ui/ui-layout/src/androidAndroidTest/kotlin/androidx/compose/foundation/layout/OnPositionedTest.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/ButtonTest.kt
Description
OnChldPositioned should be removed. OnPositioned should be used on the child layout. OnChildPositioned was only needed before we had modifiers on all layouts.