Fixed
Status Update
No update yet.
Comments
fu...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 942452ada52eebee0c518717a9acdbfd86d909f5
Author: leo huang <leohuang@google.com>
Date: Tue Aug 18 01:59:29 2020
Lock the flash mode when image capture pipeline is processing
In ImageCapture, all attemps to change flash mode during picture taken will be saved and only the latest flash mode value will be applied after picture taken is complete.
"Relnote: Fixed the issue that flash on some devices would not turn off. It happens when the flash mode is set to FLASH_MODE_ON to take picture, and is changed to FLASH_MODE_OFF when the flash fired. The symptom is like torch mode enabled."
Bug: 162568128
Test: ./gradlew camera:camera-core:test; ./gradlew camera:camera-camera2:test; ./gradlew camera:camera-core:connectedAndroidTest; ./gradlew camera:camera-camera2:connectedAndroidTest
Change-Id: Ib44514dbad0b8103de615e21717b11d45fb65640
M camera/camera-core/src/androidTest/java/androidx/camera/core/ImageCaptureTest.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
https://android-review.googlesource.com/1402519
Branch: androidx-master-dev
commit 942452ada52eebee0c518717a9acdbfd86d909f5
Author: leo huang <leohuang@google.com>
Date: Tue Aug 18 01:59:29 2020
Lock the flash mode when image capture pipeline is processing
In ImageCapture, all attemps to change flash mode during picture taken will be saved and only the latest flash mode value will be applied after picture taken is complete.
"Relnote: Fixed the issue that flash on some devices would not turn off. It happens when the flash mode is set to FLASH_MODE_ON to take picture, and is changed to FLASH_MODE_OFF when the flash fired. The symptom is like torch mode enabled."
Bug: 162568128
Test: ./gradlew camera:camera-core:test; ./gradlew camera:camera-camera2:test; ./gradlew camera:camera-core:connectedAndroidTest; ./gradlew camera:camera-camera2:connectedAndroidTest
Change-Id: Ib44514dbad0b8103de615e21717b11d45fb65640
M camera/camera-core/src/androidTest/java/androidx/camera/core/ImageCaptureTest.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
le...@google.com
The solution was merged and will be released on beta09.
Description
CAMERAX VERSION: 1.0.0-beta07
ANDROID OS BUILD NUMBER: PRP1.180610.011.C960USQS7CSK3 and PKQ1.180729.001
DEVICE NAME: Samsung S9 and Xiaomi Mi 8
DESCRIPTION: Camera Flash becomes to Flashlight mode if FlashMode is set to FLASH_MODE_OFF while the flash is working.
STEPS TO REPRODUCE:
OBSERVED RESULTS: Flash is working in Flashlight mode
EXPECTED RESULTS: Flash should be turned off
REPRODUCIBILITY: 10 of 10
ADDITIONAL INFORMATION: The problem was noticed on Samsung S9 and Xiaomi Mi 8. Other devices work properly.
CODE FRAGMENTS: