Conditional keep rule not triggered by other keep rule [162921738]

Fixed

Bug

Status Update

No update yet.

Description

sg...@google.com

created issue #1

Aug 5, 2020 12:28PM

Given the following class:

public class MyClass {
    @MyAnnotation int x;
    int y;
    public void foo() {}
    public void bar() {}
}

And a use of field x in the program like this:

   new MyClass().x = 42

The following conditional keep rule will keep all members of MyClass as expected.

-if class * {
  @**.MyAnnotation *** *;
}
-keep class <1> {
  *;
}

However, if the use of field x is removed, and the following keep rule added instead:

-keep class * {
  @**.MyAnnotation <fields>;
}

then only field x is kept in MyClass.

Comments

sg...@google.com <sg...@google.com> #2Aug 5, 2020 12:31PM

Context: https://stackoverflow.com/questions/63162818/how-to-keep-class-members-untouched-if-it-contains-a-field-with-an-annotation-i

Tested with Android Studio 4.2.0-canary07.

mk...@google.com <mk...@google.com> #3Aug 5, 2020 12:33PM

Reassigned to mk...@google.com.

This may be related to b/162900580

ap...@google.com <ap...@google.com> #4Aug 6, 2020 08:53AM

Project: r8
Branch: master

commit a5b300cc3ef4115a647659495fc81eee0a3dfa9c
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Thu Aug 06 10:46:28 2020

Check for live fields when filtering members for if rule evaluation

Bug: 162921738
Change-Id: I3a1888f76513ab57ad714db90778d90456aea018

M src/main/java/com/android/tools/r8/shaking/Enqueuer.java
M src/main/java/com/android/tools/r8/shaking/IfRuleEvaluator.java
A src/test/java/com/android/tools/r8/shaking/ifrule/IfOnAnnotationWithWildcardTest.java

https://r8-review.googlesource.com/52744

ap...@google.com <ap...@google.com> #5Aug 6, 2020 01:52PM

Project: r8
Branch: 2.1

commit a9a9edbe8c7ded7d6e8b78c5cd2436ad63638c36
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Thu Aug 06 11:55:36 2020

Version 2.1.58

Cherry-pick: Check for live fields when filtering members for if rule
evaluation
CL:

https://r8-review.googlesource.com/52744

Bug: 162921738
Change-Id: Iddbe9adba028d661a1a94a1143b5c871b845ccf6

M src/main/java/com/android/tools/r8/Version.java
M src/main/java/com/android/tools/r8/shaking/Enqueuer.java
M src/main/java/com/android/tools/r8/shaking/IfRuleEvaluator.java
A src/test/java/com/android/tools/r8/shaking/ifrule/IfOnAnnotationWithWildcardTest.java

https://r8-review.googlesource.com/52748

mk...@google.com <mk...@google.com> Aug 10, 2020 08:12AM

Marked as fixed.

Issue 162921738