LazyColumnFor + animateContentSize crashes [163066980]

Fixed

Bug

Status Update

No update yet.

Description

se...@google.com

created issue #1

Aug 6, 2020 08:41PM

Dev16

Example project attached with repro. To cause crash add enough items to enable scrolling then scroll the list.

Code that causes crash is:

        LazyColumnFor(
            items = items,
            modifier = Modifier.weight(1f),
            contentPadding = InnerPadding(top = 8.dp)
        ) { todo ->
            Box(
                // TODO: This causes LazyColumnFor to crash so disabling for now
                Modifier.animateContentSize()
            ) {
                if (currentlyEditing?.id == todo.id) {
                    TodoItemInlineEditor(
                        item = currentlyEditing,
                        onEditItemChange = onEditItemChange,
                        onEditDone = onEditDone,
                        onRemoveItem = { onRemoveItem(todo) }
                    )
                } else {
                    TodoRow(
                        todo,
                        { onStartEdit(it) },
                        Modifier.fillParentMaxWidth()
                    )
                }
            }
        }

E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.example.statecodelab, PID: 15867
    java.lang.IllegalArgumentException: LayoutNode@a609c3e children: 2 measureBlocks: androidx.compose.ui.LayoutKt$measureBlocksOf$1@ce323fe is not ready. layoutState is NeedsRelayout
        at androidx.compose.ui.node.InnerPlaceable.draw(InnerPlaceable.kt:140)
        at androidx.compose.ui.node.ModifiedLayoutNode.draw(ModifiedLayoutNode.kt:81)
        at androidx.compose.ui.node.LayerWrapper$layer$1.invoke(Unknown Source:10)
        at androidx.compose.ui.node.LayerWrapper$layer$1.invoke(Unknown Source:3)
        at androidx.compose.ui.platform.RenderNodeLayer$updateDisplayList$1$1.invoke(RenderNodeLayer.kt:186)
        at androidx.compose.ui.platform.RenderNodeLayer$updateDisplayList$1$1.invoke(Unknown Source:0)
        at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:1668)
        at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:127)
        at androidx.compose.ui.platform.AndroidComposeView.observeLayerModelReads(AndroidComposeView.kt:456)
        at androidx.compose.ui.platform.RenderNodeLayer.updateDisplayList(RenderNodeLayer.kt:185)
        at androidx.compose.ui.platform.AndroidComposeView.dispatchDraw(AndroidComposeView.kt:501)
        at android.view.View.draw(View.java:22345)
        at android.view.View.updateDisplayListIfDirty(View.java:21218)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4428)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4401)
        at android.view.View.updateDisplayListIfDirty(View.java:21178)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4428)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4401)
        at android.view.View.updateDisplayListIfDirty(View.java:21178)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4428)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4401)
        at android.view.View.updateDisplayListIfDirty(View.java:21178)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4428)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4401)
        at android.view.View.updateDisplayListIfDirty(View.java:21178)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4428)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4401)
        at android.view.View.updateDisplayListIfDirty(View.java:21178)
        at android.view.ThreadedRenderer.updateViewTreeDisplayList(ThreadedRenderer.java:559)
        at android.view.ThreadedRenderer.updateRootDisplayList(ThreadedRenderer.java:565)
        at android.view.ThreadedRenderer.draw(ThreadedRenderer.java:642)
        at android.view.ViewRootImpl.draw(ViewRootImpl.java:4079)
        at android.view.ViewRootImpl.performDraw(ViewRootImpl.java:3806)
        at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:3077)
        at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1943)
        at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:8151)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:972)
        at android.view.Choreographer.doCallbacks(Choreographer.java:796)
        at android.view.Choreographer.doFrame(Choreographer.java:731)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:957)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:223)
        at android.app.ActivityThread.main(ActivityThread.java:7656)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

StateCodelab_animateContentSize.zip

2.7 MB

Download

Comments

ma...@google.com <ma...@google.com> #2Aug 6, 2020 09:04PM

Assigned to ry...@google.com.

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

an...@google.com <an...@google.com> #3Aug 27, 2020 04:53PM

Reassigned to an...@google.com.

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

ap...@google.com <ap...@google.com> #4Sep 9, 2020 03:48PM

Marked as fixed.

Another problem I am facing with autofill is that it won't save my credentials. I tried forcing to finish the context as described here, but it won't do that either although I filled in the username with the one provided by the Google autofill service.

Issue 163066980

Description

Issue summary

Comments

ma...@google.com <ma...@google.com> #2Aug 6, 2020 09:04PM

an...@google.com <an...@google.com> #3Aug 27, 2020 04:53PM

ap...@google.com <ap...@google.com> #4Sep 9, 2020 03:48PM

Add comment

Issue metadata