Fixed
Status Update
Comments
ma...@google.com <ma...@google.com> #2
Seems like the issus is on the layout side. Assigning to Ryan
an...@google.com <an...@google.com> #3
Probably the same root issue as with b/165921895 . Investigating
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 308929cf794a4e3cb1c1adca86bc62ee32ad1613
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Thu Sep 03 17:07:40 2020
Fix crash and items of LazyColumn being incorrectly drawn
If the child LayoutNode was not placed its layers invalidation is still scheduled and we ended up drawing not measured node or just drawing the incorrect state of the node. And then we didn't redraw it correctly next time when the parent finally placed the node as it was already invalidated and not dirty anymore.
Test: InvalidatingNotPlacedChildTest, manually
Relnote: Fix for items of LazyColumn being incorrectly drawn sometimes, this was also causing crashes in some conditions.
Fixes: 163066980
Fixes: 165921895
Change-Id: Ibcf1745e40606f6a38d9eb90f915443935d34403
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/InvalidatingNotPlacedChildTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/InnerPlaceable.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayerWrapper.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
https://android-review.googlesource.com/1419311
Branch: androidx-master-dev
commit 308929cf794a4e3cb1c1adca86bc62ee32ad1613
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Thu Sep 03 17:07:40 2020
Fix crash and items of LazyColumn being incorrectly drawn
If the child LayoutNode was not placed its layers invalidation is still scheduled and we ended up drawing not measured node or just drawing the incorrect state of the node. And then we didn't redraw it correctly next time when the parent finally placed the node as it was already invalidated and not dirty anymore.
Test: InvalidatingNotPlacedChildTest, manually
Relnote: Fix for items of LazyColumn being incorrectly drawn sometimes, this was also causing crashes in some conditions.
Fixes: 163066980
Fixes: 165921895
Change-Id: Ibcf1745e40606f6a38d9eb90f915443935d34403
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/InvalidatingNotPlacedChildTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/InnerPlaceable.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayerWrapper.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
Description
Dev16
Example project attached with repro. To cause crash add enough items to enable scrolling then scroll the list.
Code that causes crash is: