Status Update
Comments
cl...@google.com <cl...@google.com>
so...@google.com <so...@google.com> #2
Thanks for reporting the issue.
The screen is visually fine but the clicks now corresponds to the clicks that we would have if the shift was still on...
Could you please clarify if the keyboard is hidden or not, and what clicks we are talking about? It would be even better if you could add the steps to reproduce the issue.
ro...@gmail.com <ro...@gmail.com> #3
Here are the steps to reproduce the issue:
Precondition: Textfield at the Bottom of the screen
Step 1:
-Click on the textfield (the keyboard should be shown and the content of the screen shifted up, if not: hide the keyboard and click on the textfield again)
Step 2:
-Hide Keyboard (After this second step, the screen goes back to normal (no more shifted) but all the interactions with the screen (clicks) works as if the screen was still shifted.)
so...@google.com <so...@google.com> #4
Thank you for the update, I can confirm that I was able to reproduce the bug.
ch...@google.com <ch...@google.com> #5
Sounds to me like the Activity is in adjustPan mode (due to
sh...@google.com <sh...@google.com> #6
Anastasia, I'm going to ahead and take this bug as it is likely in the code I'm more familiar with. If you want it back, just take it. :)
sh...@google.com <sh...@google.com> #7
Investigated and there is an issue when the keyboard causes the root View (or Window) to translate. We are investigating a fix for it but in the meantime, setting "android:windowSoftInputMode" to "adjustResize" steps around the issue.
ca...@gmail.com <ca...@gmail.com> #8
Hey guys. I've tried setting android:windowSoftInputMode to adjustResize in the AndroidManifest part for the used Activity, but it doesn't seem to prevent the issue from occuring. Neither do any of the other options I've tried. Might there be another way to step around it for now?
sh...@google.com <sh...@google.com> #9
Hmm, when you set to adjustResize, does the UI of your app still translate? (It shouldn't). When I set our demo app to adjustResize, the app does not translate, and it seems that pointer input positions are still accurate.
ca...@gmail.com <ca...@gmail.com> #10
Ah I was setting it in manifest.application, seems you need to set it in manifest.application.activity. Works now, thanks!
ap...@google.com <ap...@google.com> #11
Branch: androidx-master-dev
commit ccfdf89f6943e946a13a0482be7c2eed91599254
Author: Shep Shapard <shepshapard@google.com>
Date: Wed Sep 16 11:22:28 2020
Fixed: soft keys with adjustPan broke positions.
Bug: 163077821
Test: No new tests as it proved very difficult to do so, TODO to follow up, manually verified.
Test: ./gradlew compose:ui:ui:connectedCheck
Test: ./gradlew compose:ui:ui:test
RelNote: "Fixed bug: If the software keyboard showing caused
the app to translate, pointer input coordinates would become
incorrect."
Change-Id: Ic4cec6cf5134c024fe544f130676a4be2dfd00bd
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.kt
Description
The screen is visually fine but the clicks now corresponds to the clicks that we would have if the shift was still on...