Status Update
No update yet.
Comments
cl...@google.com
so...@google.com
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
ro...@gmail.com
so...@google.com
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ch...@google.com
Sounds to me like the Activity is in adjustPan mode (due to
sh...@google.com
Anastasia, I'm going to ahead and take this bug as it is likely in the code I'm more familiar with. If you want it back, just take it. :)
sh...@google.com
Investigated and there is an issue when the keyboard causes the root View (or Window) to translate. We are investigating a fix for it but in the meantime, setting "android:windowSoftInputMode" to "adjustResize" steps around the issue.
ca...@gmail.com
Hey guys. I've tried setting android:windowSoftInputMode to adjustResize in the AndroidManifest part for the used Activity, but it doesn't seem to prevent the issue from occuring. Neither do any of the other options I've tried. Might there be another way to step around it for now?
sh...@google.com
Hmm, when you set to adjustResize, does the UI of your app still translate? (It shouldn't). When I set our demo app to adjustResize, the app does not translate, and it seems that pointer input positions are still accurate.
ca...@gmail.com
Ah I was setting it in manifest.application, seems you need to set it in manifest.application.activity. Works now, thanks!
ap...@google.com
Branch: androidx-master-dev
commit ccfdf89f6943e946a13a0482be7c2eed91599254
Author: Shep Shapard <shepshapard@google.com>
Date: Wed Sep 16 11:22:28 2020
Fixed: soft keys with adjustPan broke positions.
Bug: 163077821
Test: No new tests as it proved very difficult to do so, TODO to follow up, manually verified.
Test: ./gradlew compose:ui:ui:connectedCheck
Test: ./gradlew compose:ui:ui:test
RelNote: "Fixed bug: If the software keyboard showing caused
the app to translate, pointer input coordinates would become
incorrect."
Change-Id: Ic4cec6cf5134c024fe544f130676a4be2dfd00bd
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.kt
Description
The screen is visually fine but the clicks now corresponds to the clicks that we would have if the shift was still on...