Status Update
No update yet.
Comments
ap...@google.com
Branch: androidx-main
commit 50077dda4e9d32caa081fa9dcf71126ad255bdec
Author: Max Alfonso-Ying <maxying@google.com>
Date: Tue May 02 20:35:20 2023
Fix NavigationBar layout in edge cases
Old behavior: Icon was a fixed distance from the top.
Label was a fixed distance from the bottom.
New behavior: Icon and label are now grouped together as
one unit, which is positioned in the center.
For the standard nav bar, this is a no-op. But this now fixes
the case when height is smaller than expected or font size is
larger than expected.
Bug:
Test: updated NavigationBarTest, NavigationBarScreenshotTest
Change-Id: I72d6bed7fb4e05392c1e9e964d7d3798e76a71ba
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/NavigationBarScreenshotTest.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/NavigationBarTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationBar.kt
ca...@google.com
Branch: androidx-main
commit a719038d0c998e63a8cc051f7cf4d33e4848d391
Author: Max Alfonso-Ying <maxying@google.com>
Date: Thu May 04 19:23:13 2023
Handle long labels more gracefully in BottomNavigation
Essentially a port of aosp/2576690 to the M2 version.
This is a no-op for the component in the default case,
but multiline labels (which are discouraged by the spec)
no longer collide with the icon.
Bug:
Test: Updated BottomNavigationTest
Change-Id: Ib9c491b586a1cda05836cce442f6391131eb6c2e
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomNavigation.kt
bl...@gmail.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material:material:1.5.0-beta01androidx.compose.material3:material3:1.2.0-alpha02androidx.compose.material3:material3-android:1.2.0-alpha02
bl...@gmail.com
Hi, For sure it is better, but with 5 items we can still reproduce this without even the larger font. Could you please fix that so the text do not overlap the icon?
ma...@google.com
It seems with the introduction of
Google Photo APP version: 6.54.0.566308615
As mentioned in the release note, the system has embraced a non-linear scaling curve. This approach yields a situation in which larger text components do not undergo scaling in proportion to smaller text components. For instance, a header text element may remain unaffected by size changes, while the smaller text positioned below the header may enlarge. Similarly, it appears the BottomNavigation component at the bottom is also influenced by this non-linear scaling in a similar manner. And thus text is cut-off by the image placed in the group.
ke...@gmail.com
@NavigationBar should be able to support text of any size, so long as the component is allowed to grow in height. See the attachment for an even more extreme example.
@
Description
Currently creating a
SwipeableStateinvolves some boiler-plate:SwipeableStateAnimationClockObservableis and how I procure one.rememberit.A factory function producing this for me would be very convenient.