Expose swipeableStateFor [163132293]

Fixed

Feature Request

Status Update

No update yet.

Description

ni...@google.com

created issue #1

Aug 7, 2020 03:57PM

Currently creating a SwipeableState involves some boiler-plate:

Creating a type extending SwipeableState
Work out what a AnimationClockObservable is and how I procure one.
Remember to remember it.

A factory function producing this for me would be very convenient.

Comments

ap...@google.com <ap...@google.com> #2Aug 11, 2020 01:55PM

Project: platform/frameworks/support
Branch: androidx-main

commit eb4ba29681b6eceb06c1cc154381514fd73518d7
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Mon Jan 18 16:36:00 2021

Add layoutDirection param to Shape's createOutline

Bug: 152756983
Test: ClipDrawTest
Relnote: Add layoutDirection param to Shape's createOutline. This allows to create layout direction aware shapes.
Change-Id: I57c20c45978b5468556159966bd9836653a2e40d

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BackgroundTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BorderTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/CornerBasedShapeTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/CutCornerShapeTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/RoundedCornerShapeTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Background.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Border.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/shape/CornerBasedShape.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/shape/GenericShape.kt
M compose/integration-tests/src/main/java/androidx/ui/integration/test/core/ComponentWithTwoLayoutNodesTestCase.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/ButtonDemo.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/ColorPickerDemo.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/AppBar.kt
M compose/test-utils/src/androidMain/kotlin/androidx/compose/testutils/ImageAssertions.kt
M compose/ui/ui-graphics/api/current.txt
M compose/ui/ui-graphics/api/public_plus_experimental_current.txt
M compose/ui/ui-graphics/api/restricted_current.txt
M compose/ui/ui-graphics/src/androidAndroidTest/kotlin/androidx/compose/ui/graphics/RectangleShapeTest.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/RectangleShape.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/Shape.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/AndroidLayoutDrawTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/ClipDrawTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/GraphicsLayerTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/ShadowTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/OutlineResolver.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeLayer.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/ViewLayer.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNodeWrapper.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/OwnedLayer.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/OutlineCache.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/SkijaLayer.kt
M compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/SkijaLayerTest.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/graphics/GraphicsLayerScopeTest.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/node/LayoutNodeTest.kt

https://android-review.googlesource.com/1553502

ca...@google.com <ca...@google.com> #3Aug 11, 2020 01:57PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit dd1e77d4c753bd3e41d094987cee6e7e6c13124c
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Wed Jan 20 20:01:28 2021

Make RounderCornerShape/CutCornerShape layout direction aware

Relnote: Parameters on RounderCornerShape, CutCornerShape and CornerBasedShape were renamed from left/right to start/end in order to support the shape's auto mirroring in the rtl direction. AbsoluteRounderCornerShape and AbsoluteCutCornerShape were introduced for the cases when auto-mirroring is not desired.
Fixes: 152756983
Test: CutCornerShapeTest, RoundedCornerShapeTest, CutCornerShape
Change-Id: I61040b7bba950191361af89ff4c736ef6cb56235

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/AbsoluteCutCornerShapeTest.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/AbsoluteRoundedCornerShapeTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/CornerBasedShapeTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/CutCornerShapeTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/RoundedCornerShapeTest.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/shape/AbsoluteCutCornerShape.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/shape/AbsoluteRoundedCornerShape.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/shape/CornerBasedShape.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/shape/CutCornerShape.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/shape/RoundedCornerShape.kt
M compose/integration-tests/docs-snippets/src/main/java/androidx/compose/integration/docs/theming/Theming.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BackdropScaffold.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/ui/ui-tooling/src/androidTest/java/androidx/compose/ui/tooling/TestAnimationPreview.kt
M compose/ui/ui-tooling/src/androidTest/java/androidx/compose/ui/tooling/inspector/ParameterFactoryTest.kt

https://android-review.googlesource.com/1555239

bl...@gmail.com <bl...@gmail.com> #4Apr 21, 2022 11:50AM

Regression in material3: the function is now marked internal. Please re-open.

bl...@gmail.com <bl...@gmail.com> #5Apr 21, 2022 11:53AM

https://cs.android.com/androidx/platform/frameworks/support/+/4e99cad7cfba400da47af86a08f68df6b40c6e51

ma...@google.com <ma...@google.com> #6Apr 21, 2022 12:58PM

Thanks for your feedback. We are looking into the ways of improving the current Mosidifer.swipeable, it has a number of critical bugs and we don't want to publish it as-is in material3. Stay tuned

ke...@gmail.com <ke...@gmail.com> #7May 19, 2022 11:14AM

I would like to add one thing (if it's not planned in the new swipeable() yet).

Right now, if you add an anchor, lets say 0..100 then it works as expected if you swipe from left (0) to right (100). However when doing the opposite swipe (from right 100 to left 0), instead of just not doing anything, swipeable shows the "overscroll" (or rather "overstretch") effect and consumes the scroll events if it's located in a horizontally scrollable container.

For example, let's say I want to put swipeable elements inside of the drawer. I want to be able to swipe to the right to "remove" the elements but I also want to be able to close the drawer by swiping to the left. Right now the drawer is impossible to close by swiping to the left. There needs to be some kind of a flag to disable this default behavior and to hint the swipeable to not consume scroll events in this and similar cases.

Message last modified on May 19, 2022 11:15AM

Issue 163132293