Fixed
Status Update
No update yet.
Comments
ap...@google.com
Hello,
This issue report has been forwarded to the Vertex AI Workbench Engineering team so that they may investigate it, but there is no ETA for a resolution today. Future updates regarding this issue will be provided here.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit e084fe15368aa75a422e3b65cbed3cd33f0c3a23
Author: Shep Shapard <shepshapard@google.com>
Date: Mon Aug 10 13:31:52 2020
Reland: TapGestureFilter that does not consume.
Reland of (aosp/1395827) because of a
binary conflict with another CL that
caused a build failure.
That has been resolved.
See bug for details as to why this needs
to exist.
TLDR: Multiple top level systems want to
know if the user tapped on an empty gesture
space in the app so that they each can
respond. The only way for each to respond
is to have a TapGestureFilter that does not
block TapGestureFilters. This is that.
Fixes: 163421610
Test: ./gradlew compose:ui:ui:test
Test: ./gradlew compose:ui:ui:connectedCheck
Change-Id: I02105bd45d60ed31eb727366a85ce062470c55a3
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/gesture/TapGestureFilter.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/selection/SelectionContainer.kt
M ui/ui-core/src/test/kotlin/androidx/compose/ui/gesture/TapGestureFilterTest.kt
M ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/SelectionContainerTest.kt
https://android-review.googlesource.com/1396971
Branch: androidx-master-dev
commit e084fe15368aa75a422e3b65cbed3cd33f0c3a23
Author: Shep Shapard <shepshapard@google.com>
Date: Mon Aug 10 13:31:52 2020
Reland: TapGestureFilter that does not consume.
Reland of (aosp/1395827) because of a
binary conflict with another CL that
caused a build failure.
That has been resolved.
See bug for details as to why this needs
to exist.
TLDR: Multiple top level systems want to
know if the user tapped on an empty gesture
space in the app so that they each can
respond. The only way for each to respond
is to have a TapGestureFilter that does not
block TapGestureFilters. This is that.
Fixes: 163421610
Test: ./gradlew compose:ui:ui:test
Test: ./gradlew compose:ui:ui:connectedCheck
Change-Id: I02105bd45d60ed31eb727366a85ce062470c55a3
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/gesture/TapGestureFilter.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/selection/SelectionContainer.kt
M ui/ui-core/src/test/kotlin/androidx/compose/ui/gesture/TapGestureFilterTest.kt
M ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/SelectionContainerTest.kt
Description
At the root of compose we have at least a couple of systems that want to be aware of when a tap occurs in a space in an app where nothing responds to the tap. The easiest way to be aware that a tap in empty space occurred is to add a TapGestureFilter to the root. However, doing so will prevent anything else that may be higher from knowing the same thing.
In order to allow for multiple root level systems to know that a tap occurred in "dead space" in the app, a special TapGestureFilter needs to be created that will not consume the up event (so that other special TapGestureFilters higher up will also be able to know the same information).