Support composed{} based modifier in parameter inspection [163494569]

Fixed

Feature Request

Status Update

No update yet.

Description

ma...@google.com

created issue #1

Aug 11, 2020 01:11PM

We want to be able to expect modifiers that are based on the composed{} construct and it's not possible right now because we need to have composition scope to be able to materialize them.

For example, Modifier.border is based on composed{} and we're not able to currently inspect its parameters.

Comments

ch...@google.com <ch...@google.com> #2Aug 12, 2020 06:13PM

Hi,

I also see my text cut off when I set maxLines = 2. Is it the same issue?

  Box(
    modifier =
      Modifier.size(
        width = 108dp,
        height = 34dp,
      ),
    contentAlignment = Alignment.Center,
  ) {
    BasicText(
      text = "text text text",
      maxLines = 2,
      autoSize = AutoSize.StepBased(minFontSize = 1.sp, maxFontSize = 13.sp, stepSize = 0.2.sp),
    )
  }

jl...@google.com <jl...@google.com> #3Aug 12, 2020 10:00PM

Reassigned to ch...@google.com.

Project: platform/frameworks/support
Branch: androidx-main
Author: Jossi Wolf <jossiwolf@google.com>
Link: https://android-review.googlesource.com/3450389

Fix TextAutoSize bug with maxLines = 1

Expand for full commit details

Fix TextAutoSize bug with maxLines = 1 
 
We were overcaching the paragraphIntrinsics in MultiParagraphLayoutCache when mutating the style. For `AutoSizeStepBased` instances with biased windows (more values smaller/bigger than the optimal), this could result in performing layout with outdated intrinsics, and thus an outdated style and font size, without surfacing this in the TextLayoutResult. 
 
Test: New MultiParagraphLayoutCacheTests and manual testing 
Relnote: Fixed a bug in BasicText with TextAutoSize and maxLines set to 1. 
Fixes: 376834366 
 
Change-Id: Ic0450c763c5d764492995b44ee1fe570246a9689

Files:

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCacheTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCache.kt

Hash: e1b712d78cc60384ed67a56c006148291ba146a6
Date: Tue Jan 07 18:52:26 2025

ComposedModifier.png

337 KB

View

Download

ch...@google.com <ch...@google.com> #4Aug 12, 2020 10:42PM

#2, yeah, that's the same issue.

jl...@google.com <jl...@google.com> #5Aug 12, 2020 10:51PM

Reassigned to jl...@google.com.

Thanks @jo...@google.com for fixing this! Do you know when the fix would be available for g3 apps?

jl...@google.com <jl...@google.com> #6Aug 13, 2020 01:00AM

Reassigned to ch...@google.com.

Moving the internal discussion offline. The bug is fixed and the fix available in snapshot builds. We will comment on this issue when the bug fix is included in a release.

ch...@google.com <ch...@google.com> #7Aug 13, 2020 03:47PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-beta01
androidx.compose.foundation:foundation-android:1.8.0-beta01
androidx.compose.foundation:foundation-jvmstubs:1.8.0-beta01
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-beta01

jl...@google.com <jl...@google.com> #8Aug 13, 2020 04:11PM

Reassigned to mo...@google.com.

Hi George,

Now that a modifier can be based the "composed{}" construct, the Layout Inspector has trouble displaying these modifier parameters.
An example here is:
Text(Modifier.border(width = 10.0.dp, color = Color.Black)

The parameter value seen on the CallGroup for the Text node is a "ComposedModifier" i.e. the un-materialized modifier.
Obviously the system must have calculated the materialized version somewhere.
And in fact as seen in #6 the materialized border is found in a NodeGroup under a child node 4 levels deep: Text -> Text -> CoreText -> Layout -> Layout
It would be nice we could determine that the "ComposedModifier" found for the top level Text is in fact the "BorderModifier" seen in NodeGroup.
But I fail to see how I can make that association.
Do you see a way?

mo...@google.com <mo...@google.com> #9Aug 18, 2020 03:57PM

I think I should be able to give access to the uncomposaed modifier so that you can access its information.

jl...@google.com <jl...@google.com> #10Aug 18, 2020 04:00PM

That would be great.
Thank you.

ap...@google.com <ap...@google.com> #11Oct 8, 2020 09:05PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 4faed1d7c573e5b475f549f159bbfe41278d47cd
Author: Jens Ole Lauridsen <jlauridsen@google.com>
Date: Wed Oct 07 15:01:31 2020

Add inspector info DSL to the composed modifier

This would allow the layout inspector to display information for
the unmaterialized modifiers found in the Compose parameters.

In this change: apply this for border modifiers.

Fixes: 163494569
Test: Unit test reenabled
Relnote: Add ability to specify inspector info in composed modifier
Change-Id: Idee08841816fb7dfc8f0621eb5a32c3663131aa1

M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Border.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
A compose/ui/ui/samples/src/main/java/androidx/compose/ui/samples/InspectorInfoInComposedModifierSamples.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/ComposedModifier.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/inspector/ParameterFactoryTest.kt

https://android-review.googlesource.com/1447175