Firebase perf plugin should remove deleted input classes [164332661]

Fixed

Bug

Status Update

No update yet.

Description

ga...@google.com

created issue #1

Aug 14, 2020 09:38AM

(Filing a public issue here, feel free to link it again an internal one)

Using the attached project and running:

run ./gradlew :app:assembleDebug
comment out or remove app/src/main/java/com/example/kotlinconfcaching/Data.java
uncomment mylibrary/src/main/java/com/example/kotlinconfcaching/Data.java
run ./gradlew :app:assembleDebug again

This causes build to fail with:

/home/gavra/AndroidStudioProjects/KotlinConfCaching/app/build/intermediates/project_dex_archive/debug/out/com/example/kotlinconfcaching/Data.dex: D8: Type com.example.kotlinconfcaching.Data is defined multiple times: /home/gavra/AndroidStudioProjects/KotlinConfCaching/app/build/intermediates/project_dex_archive/debug/out/com/example/kotlinconfcaching/Data.dex, /home/gavra/AndroidStudioProjects/KotlinConfCaching/app/build/intermediates/mixed_scope_dex_archive/debug/out/com/example/kotlinconfcaching/Data.dex
com.android.builder.dexing.DexArchiveMergerException: Error while merging dex archives: 
Type com.example.kotlinconfcaching.Data is defined multiple times: /home/gavra/AndroidStudioProjects/KotlinConfCaching/app/build/intermediates/project_dex_archive/debug/out/com/example/kotlinconfcaching/Data.dex, /home/gavra/AndroidStudioProjects/KotlinConfCaching/app/build/intermediates/mixed_scope_dex_archive/debug/out/com/example/kotlinconfcaching/Data.dex

Running find app/build/intermediates/transforms/FirebasePerformancePlugin/ -name Data.class shows there are 2 copies of Data.class which indicates that the one from app was not removed.

firebase-perf.zip

218 KB

Download

Comments

ki...@google.com <ki...@google.com> #2Aug 18, 2020 05:45PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit f57b5cbd142016a2d95fd7bf736262049b085aeb
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Nov 09 13:23:07 2020

Move FloatingWindow interface to Kotlin

Converted the FloatingWindow inferface to koltin and added the kotlin
std library dependency to navigation-common.

Test: ./gradlew checkApi
Bug: 172823546

Change-Id: I98af40e5c9bc747d792180990f1654d6353aa4b5

M navigation/navigation-common/build.gradle
M navigation/navigation-common/src/main/java/androidx/navigation/FloatingWindow.kt

https://android-review.googlesource.com/1492738

ga...@google.com <ga...@google.com> Aug 18, 2020 05:46PM

Reassigned to ki...@google.com.

ki...@google.com <ki...@google.com> #3Aug 20, 2020 10:22PM

Project: platform/frameworks/support
Branch: androidx-main

commit b637fdfd6b937d19d4e419c4bfba9b437af6378c
Author: Ian Lake <ilake@google.com>
Date: Thu Apr 01 16:13:27 2021

Merge Navigation Compose version back into Navigation

Rather than run Navigation Compose as a separate,
parallel project from the other Navigation artifacts,
merge the versions together so that we can better
integrate the artifacts together and leverage new
alpha features.

Test: ./gradlew bOS, ran Studio in FLAN and COMPOSE configs
BUG: 172823546
Change-Id: I139a44d95c91dc3cf2e951225aabbc2581914e95

M buildSrc/src/main/kotlin/androidx/build/LibraryVersions.kt
M navigation/navigation-compose/build.gradle
M navigation/navigation-compose/samples/build.gradle
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt
M navigation/navigation-runtime/build.gradle
M settings.gradle
M testutils/testutils-navigation/build.gradle

https://android-review.googlesource.com/1662999

ga...@google.com <ga...@google.com> #4Aug 26, 2020 09:29AM

Project: platform/frameworks/support
Branch: androidx-main

commit 51769b7a8d6d3e2032e45b3ec1e3cfe29e718ab6
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Mar 31 10:59:25 2021

Add routes to NavDestination

This change introduces the concept of a route to NavDestination. A route
is String that defines the path to the Destination. Setting the route on
a NavDestination will replace the any id that was set previously and
adds a deep link to the destination. You can set a route on the
NavDestination programatically, or through xml.

RelNote: "You can now add a route to your NavDestination"
Test: NavDestinationTest
Bug: 172823546

Change-Id: I77daf563f480ae54b9728a78e7696ea96d19f264

M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/public_plus_experimental_current.txt
M navigation/navigation-common/api/restricted_current.txt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDestinationAndroidTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDestination.kt
M navigation/navigation-common/src/main/res-public/values/public_attrs.xml
M navigation/navigation-common/src/main/res/values/attrs.xml

https://android-review.googlesource.com/1660682

rk...@google.com <rk...@google.com> #5Oct 12, 2020 06:50PM

Project: platform/frameworks/support
Branch: androidx-main

commit df16e2452d8333af236a9e5203b396b98f1056be
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Apr 05 17:19:54 2021

Add routes to NavDestination Kotlin DSL

You can now add a route to your NavDestination when using the Kotlin
DSL.

RelNote: "You can now add a route to your NavDestination via the Kotlin
DSL"
Test: NavDestinationBuilderTest
Bug: 172823546

Change-Id: I1276418c8ca0b22eb420c0be6b97f0a5d41de0f9

M navigation/navigation-common/api/api_lint.ignore
M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/public_plus_experimental_current.txt
M navigation/navigation-common/api/restricted_current.txt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDestinationBuilderTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDestinationBuilder.kt

https://android-review.googlesource.com/1660683

rk...@google.com <rk...@google.com> #6Oct 12, 2020 08:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit e6ad7e497c3006c7c1fbe701c36d45f3906c33b0
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon May 03 17:50:16 2021

Deprecated getStartDestination

Deprecating getStartDestination in favor of getStartDestinationId to
make the API more explicit.

RelNote: "The `getStartDestination()` API has been deprecated in favor
of `getStartDestinationId()`."
Test: ./gradlew checkApi
Bug: 172823546

Change-Id: I0887ffe673bea453b69dff286d5dc142ce4ef462

M compose/integration-tests/docs-snippets/src/main/java/androidx/compose/integration/docs/navigation/Navigation.kt
M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/public_plus_experimental_current.txt
M navigation/navigation-common/api/restricted_current.txt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavGraphAndroidTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDestination.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavGraph.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavGraphBuilder.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavGraphNavigator.kt
M navigation/navigation-common/src/test/java/androidx/navigation/NavDestinationTest.kt
M navigation/navigation-common/src/test/java/androidx/navigation/NavGraphNavigatorTest.kt
M navigation/navigation-common/src/test/java/androidx/navigation/NavGraphTest.kt
M navigation/navigation-compose/integration-tests/navigation-demos/src/main/java/androidx/navigation/compose/demos/BottomBarNavDemo.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavInflaterTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
M navigation/navigation-ui/src/main/java/androidx/navigation/ui/NavigationUI.kt

https://android-review.googlesource.com/1695087

ga...@google.com <ga...@google.com> Oct 12, 2020 08:20PM

Marked as fixed, reassigned to ga...@google.com.