Fixed
Status Update
No update yet.
Comments
il...@google.com
jb...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 5e3ad2f16b7d4814f413d8ae71de20bf63239477
Author: Ian Lake <ilake@google.com>
Date: Wed Mar 04 14:30:58 2020
Add a @LayoutId constructor to DialogFragment
Allow developers to provide a @LayoutId to
DialogFragment to provide parity with Fragment.
Test: Updated fragment-testing tests still pass
BUG: 150327080
Change-Id: I9b480a29921cb9a354ef9e0d209a4b7be1f91bf7
M fragment/fragment-testing/src/androidTest/java/androidx/fragment/app/testing/SimpleDialogFragment.kt
M fragment/fragment/api/1.3.0-alpha02.txt
M fragment/fragment/api/current.txt
M fragment/fragment/api/public_plus_experimental_1.3.0-alpha02.txt
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_1.3.0-alpha02.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/main/java/androidx/fragment/app/DialogFragment.java
https://android-review.googlesource.com/1250165
Branch: androidx-master-dev
commit 5e3ad2f16b7d4814f413d8ae71de20bf63239477
Author: Ian Lake <ilake@google.com>
Date: Wed Mar 04 14:30:58 2020
Add a @LayoutId constructor to DialogFragment
Allow developers to provide a @LayoutId to
DialogFragment to provide parity with Fragment.
Test: Updated fragment-testing tests still pass
BUG: 150327080
Change-Id: I9b480a29921cb9a354ef9e0d209a4b7be1f91bf7
M fragment/fragment-testing/src/androidTest/java/androidx/fragment/app/testing/SimpleDialogFragment.kt
M fragment/fragment/api/1.3.0-alpha02.txt
M fragment/fragment/api/current.txt
M fragment/fragment/api/public_plus_experimental_1.3.0-alpha02.txt
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_1.3.0-alpha02.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/main/java/androidx/fragment/app/DialogFragment.java
jb...@google.com
We've added a DialogFragment(@LayoutRes) constructor and it'll be available in Fragment 1.3.0-alpha02.
Note that subclasses of DialogFragment (such as BottomSheetDialogFragment) will need to be updated to depend on Fragment 1.3.0-alpha02 and add a constructor themselves before you'll be able to use it in those cases. You'd want to file a feature request against them.
il...@google.com
This has been fixed internally and will be available in the next release of Fragments.
Description
When using the new state manager released in fragment 1.3.0-alpha08, if you manually (without using the hide/show fragment transactions) set the visibility state of your view after the SpecialEffectsController has started any animations/transitions on your view, the visibility changes are ignored.
The reason this happens is because the new state manager saves the visibility state of the view in
onViewCreated()as the final state and then restores that visibility state once the special effect completes afteronStart(). This means that any changes made by the user to the view visibility state betweenonViewCreate()andonStart()are completely ignored.This becomes apparent in two particular cases:
There is a fragment that is always added, but has its visibility state updated based on some internal data (i.e. an error screen that is set to
View.INVISIBLEwhen there is no error andView.VISIBLEwhen there is one). If the view state changes toINVISIBLEinonStart(), the fragment should not be shown once the add transaction completes.A entering fragment is postponed and while it is postponed, its view visibility state is set to
View.INVISIBLE. Even once the fragment is no longer postponed, its view should still beINVISIBLEuntil the user changes it again manually.The new state manager should defer view visibility state control to the user no matter when the state is changed. Doing so would ensure that the user always has the source of truth for their Fragment's view visibility.