Fixed

Bug

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Aug 17, 2020 04:57PM

Issue

Currently, each child of the LazyColumnFor composable is implicitly wrapped with a key containing the index of the item. Because of this if the order of the items is changed, the children, that got reordered, are needlessly recomposed (this is because the value of the keys have changed). In the extreme case, when an item is inserted at the beginning of the list, the entire subtree of LazyColumnFor get recomposed.

Motivation

Oftentimes the items that are rendered in these lazy composables, have unique ids. Thus, it would be useful if there was a way of specifying the id of the item as a key.

Possible solution

I have thought of several solutions:

Remove the keys and encourage users to wrap each child with a key.
Add an optional function parameter that would compute the value of the key for each item.

Option 1 would function similarly to how it does in React. Not specifying a key could be a warning.

Personally, I like option 2 better. I am not sure how this parameter could be named, but its type could simply be:

(Int, T) -> Any

where Int is the index of the item
T is the type of the item
the return value would be supplied to the key

The default value for the parameter could be defined as { i, _ -> i }. This way, when the parameter is not specified LazyColumnFor (or LazyRowFor) would function exactly as it does now.

Also maybe a better type signature could be T.(Int) -> Any, this way if the user wants to use an id of the item as a key, the function would be as simple as { id } instead of { _, item -> item.id }.

Comments

ma...@google.com <ma...@google.com> #2Aug 17, 2020 05:18PM

Project: platform/frameworks/support
Branch: androidx-main

commit cb1afd67dacbf14cd22206c6f5b543dbf18cec1f
Author: Tony Mak <tonymak@google.com>
Date: Thu Jan 06 14:52:58 2022

Deprecate all the APIs in textclassifier

Bug: 210509084

Test: Check api/current.txt and ensure all classes are deprecated

Relnote: "Deprecate all the APIs in the textclassifier module"

Change-Id: Idc18063196531c0e926162fefeadf2dc5f559da1

M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextSelection.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinks.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationSessionId.java
M textclassifier/textclassifier/api/public_plus_experimental_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassification.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationManager.java
M textclassifier/textclassifier/api/current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationContext.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinksParams.java
M textclassifier/textclassifier/api/restricted_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationAction.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassifier.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationActions.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ExtrasUtils.java

https://android-review.googlesource.com/1938773

ma...@google.com <ma...@google.com> #3Aug 19, 2020 04:55PM

Reassigned to an...@google.com.

Is there any update when the alpha04 will be available? We need it to target api 31 because of the PendingIntent mutability flags missing in alpha03.

ma...@gmail.com <ma...@gmail.com> #4Sep 30, 2020 03:01PM

I'll schedule it for the next release. Note that alpha04 is a complete turn-down of the library where all APIs are marked as Deprecated, so you'll also want to start removing your usages of the library.

an...@google.com <an...@google.com> #5Sep 30, 2020 03:10PM

Project: platform/frameworks/support
Branch: androidx-main

commit 19ed7e69823a09f3c63f8c8cdf339af8ca1645ab
Author: Alan Viverette <alanv@google.com>
Date: Mon Mar 14 15:18:16 2022

Bump textclassifier for final release and turn-down

Bug: 210509084
Change-Id: Ib8b2386903bb49baa3211f7de7fe1587fdda1483
Test: ./gradlew checkApi

M libraryversions.toml

https://android-review.googlesource.com/2024823

ma...@gmail.com <ma...@gmail.com> #6Sep 30, 2020 07:05PM

Bugjuggler: wait until 2022-03-23

ap...@google.com <ap...@google.com> #7Feb 3, 2021 11:47AM

Marked as fixed.

Hi. I've received your bug and will wait until 2022-03-23 00:00 -0400 EDT and then assign the bug to alanv@google.com.

IssueTracker

Expose key in LazyColumnFor & LazyRowFor

Status Update

Description

Issue

Motivation

Possible solution

Comments

ma...@google.com <ma...@google.com> #2Aug 17, 2020 05:18PM

ma...@google.com <ma...@google.com> #3Aug 19, 2020 04:55PM

ma...@gmail.com <ma...@gmail.com> #4Sep 30, 2020 03:01PM

an...@google.com <an...@google.com> #5Sep 30, 2020 03:10PM

ma...@gmail.com <ma...@gmail.com> #6Sep 30, 2020 07:05PM

ap...@google.com <ap...@google.com> #7Feb 3, 2021 11:47AM

Issue 164901852

Description

Issue

Motivation

Possible solution

Issue summary

Comments

ma...@google.com <ma...@google.com> #2Aug 17, 2020 05:18PM

ma...@google.com <ma...@google.com> #3Aug 19, 2020 04:55PM

ma...@gmail.com <ma...@gmail.com> #4Sep 30, 2020 03:01PM

an...@google.com <an...@google.com> #5Sep 30, 2020 03:10PM

ma...@gmail.com <ma...@gmail.com> #6Sep 30, 2020 07:05PM

ap...@google.com <ap...@google.com> #7Feb 3, 2021 11:47AM

Add comment

Issue metadata