ConfigParserTest starts failing after upgrade to Kotlin 1.4 [165300826]

Fixed

Bug

Status Update

No update yet.

Description

au...@google.com

created issue #1

Aug 18, 2020 05:16PM

java.lang.Exception: Unexpected exception, expected<java.lang.IllegalArgumentException> but was<java.lang.NullPointerException>
	at org.junit.internal.runners.statements.ExpectException.evaluate(ExpectException.java:28)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:110)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
	at org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:62)
	at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33)
	at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:94)
	at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:119)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:182)
	at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:164)
	at org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:414)
	at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
	at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:48)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:56)
	at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.lang.NullPointerException: Parameter specified as non-null is null: method kotlin.collections.CollectionsKt___CollectionsKt.filterNotNull, parameter $this$filterNotNull
	at kotlin.collections.CollectionsKt___CollectionsKt.filterNotNull(_Collections.kt)
	at com.android.tools.build.jetifier.core.config.Config$JsonData.toConfig(Config.kt:233)
	at com.android.tools.build.jetifier.core.config.ConfigParser.parseFromString(ConfigParser.kt:43)
	at com.android.tools.build.jetifier.core.config.ConfigParserTest.parseConfig_duplicity_shouldFail(ConfigParserTest.kt:156)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.ExpectException.evaluate(ExpectException.java:19)
	... 39 more

Comments

ap...@google.com <ap...@google.com> #2Aug 27, 2020 08:30PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 33ebdb9c4da8e3bbdc297bab586eeb84d1e83855
Author: Aurimas Liutikas <aurimas@google.com>
Date: Mon Aug 17 08:53:12 2020

Upgrade androidx to Kotlin 1.4

- clean up new Kotlin warnings after upgrading.
- enable multidex for appcompat and preference tests as
we are hitting dex limit
- remove new redundant extension method in fragment-ktx

Test: ./busytown/androidx.sh
Bug: 165307851, 165300826
Relnote: Upgrade androidx to use Kotlin 1.4

Change-Id: Id647100407925c16d734c8c43392b4e2d108d0e3

M appcompat/appcompat/build.gradle
M appcompat/appcompat/src/androidTest/AndroidManifest.xml
M buildSrc/build_dependencies.gradle
M camera/integration-tests/camerapipetestapp/src/main/java/androidx/camera/integration/camera2/pipe/CameraPipeApplication.kt
M camera/integration-tests/camerapipetestapp/src/main/java/androidx/camera/integration/camera2/pipe/SimpleCamera.kt
M camera/integration-tests/timingtestapp/src/main/java/androidx/camera/integration/antelope/CameraUtils.kt
M core/core-ktx/src/androidTest/java/androidx/core/view/ViewTest.kt
M dynamic-animation/dynamic-animation-ktx/api/current.txt
M dynamic-animation/dynamic-animation-ktx/api/public_plus_experimental_current.txt
M dynamic-animation/dynamic-animation-ktx/api/restricted_current.txt
M fragment/fragment-ktx/api/current.txt
M fragment/fragment-ktx/api/public_plus_experimental_current.txt
M fragment/fragment-ktx/api/restricted_current.txt
M fragment/fragment-ktx/src/main/java/androidx/fragment/app/Fragment.kt
D fragment/fragment-ktx/src/main/java/androidx/fragment/app/FragmentResultOwner.kt
M gradle.properties
M jetifier/jetifier/core/src/test/kotlin/com/android/tools/build/jetifier/core/config/ConfigParserTest.kt
M jetifier/jetifier/processor/src/main/kotlin/com/android/tools/build/jetifier/processor/Processor.kt
M lifecycle/integration-tests/kotlintestapp/src/test-common/java/androidx.lifecycle/LifecycleCoroutineScopeTestBase.kt
M lifecycle/lifecycle-livedata-core-ktx/src/test/java/androidx/lifecycle/LiveDataTest.kt
M lifecycle/lifecycle-livedata-ktx/src/test/java/androidx/lifecycle/TransformationsTest.kt
M lifecycle/lifecycle-viewmodel-ktx/src/androidTest/java/androidx/lifecycle/ViewModelTest.kt
M navigation/navigation-safe-args-gradle-plugin/src/test/kotlin/androidx/navigation/safeargs/gradle/IncrementalPluginTest.kt
M navigation/navigation-safe-args-gradle-plugin/src/test/kotlin/androidx/navigation/safeargs/gradle/KotlinPluginTest.kt
M paging/common/src/main/kotlin/androidx/paging/PagePresenter.kt
M paging/common/src/test/kotlin/androidx/paging/CachingTest.kt
M paging/samples/src/main/java/androidx/paging/samples/PagingDataAdapterSample.kt
M preference/preference/build.gradle
M recyclerview/recyclerview/src/androidTest/java/androidx/recyclerview/widget/LinearLayoutManagerRemoveShownItemsTest.kt
M room/compiler/src/test/kotlin/androidx/room/ext/ElementExtTest.kt
M room/compiler/src/test/kotlin/androidx/room/processor/PojoProcessorTargetMethodTest.kt
M room/compiler/src/test/kotlin/androidx/room/processor/PojoProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/processor/ProjectionExpanderTest.kt
M room/compiler/src/test/kotlin/androidx/room/processor/autovalue/AutoValuePojoProcessorDelegateTest.kt
M room/compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/BooksDaoTest.kt
M samples/Support4Demos/src/main/java/com/example/android/supportv4/app/FragmentViewModelSupport.kt
M viewpager2/viewpager2/src/androidTest/java/androidx/viewpager2/widget/MutableCollectionsTest.kt

https://android-review.googlesource.com/1399323

pa...@google.com <pa...@google.com> #3Sep 3, 2020 11:26AM

Marked as fixed, reassigned to pa...@google.com.

Fixed in https://android-review.googlesource.com/c/platform/frameworks/support/+/1417171

ap...@google.com <ap...@google.com> #4Nov 29, 2021 01:37AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 33ebdb9c4da8e3bbdc297bab586eeb84d1e83855
Author: Aurimas Liutikas <aurimas@google.com>
Date: Mon Aug 17 08:53:12 2020

Upgrade androidx to Kotlin 1.4

- clean up new Kotlin warnings after upgrading.
- enable multidex for appcompat and preference tests as
we are hitting dex limit
- remove new redundant extension method in fragment-ktx

Test: ./busytown/androidx.sh
Bug: 165307851, 165300826
Relnote: Upgrade androidx to use Kotlin 1.4

Change-Id: Id647100407925c16d734c8c43392b4e2d108d0e3

M lifecycle/lifecycle-viewmodel-ktx/src/androidTest/java/androidx/lifecycle/ViewModelTest.kt
M lifecycle/integration-tests/kotlintestapp/src/test-common/java/androidx.lifecycle/LifecycleCoroutineScopeTestBase.kt
M appcompat/appcompat/build.gradle
M navigation/navigation-safe-args-gradle-plugin/src/test/kotlin/androidx/navigation/safeargs/gradle/IncrementalPluginTest.kt
M room/compiler/src/test/kotlin/androidx/room/processor/autovalue/AutoValuePojoProcessorDelegateTest.kt
M lifecycle/lifecycle-livedata-core-ktx/src/test/java/androidx/lifecycle/LiveDataTest.kt
M camera/integration-tests/camerapipetestapp/src/main/java/androidx/camera/integration/camera2/pipe/CameraPipeApplication.kt
M buildSrc/build_dependencies.gradle
M jetifier/jetifier/processor/src/main/kotlin/com/android/tools/build/jetifier/processor/Processor.kt
M samples/Support4Demos/src/main/java/com/example/android/supportv4/app/FragmentViewModelSupport.kt
M appcompat/appcompat/src/androidTest/AndroidManifest.xml
M dynamic-animation/dynamic-animation-ktx/api/restricted_current.txt
M preference/preference/build.gradle
M paging/common/src/main/kotlin/androidx/paging/PagePresenter.kt
M lifecycle/lifecycle-livedata-ktx/src/test/java/androidx/lifecycle/TransformationsTest.kt
M room/compiler/src/test/kotlin/androidx/room/processor/PojoProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/processor/PojoProcessorTargetMethodTest.kt
M room/compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
M jetifier/jetifier/core/src/test/kotlin/com/android/tools/build/jetifier/core/config/ConfigParserTest.kt
M dynamic-animation/dynamic-animation-ktx/api/current.txt
M fragment/fragment-ktx/api/public_plus_experimental_current.txt
M paging/samples/src/main/java/androidx/paging/samples/PagingDataAdapterSample.kt
M fragment/fragment-ktx/api/current.txt
M core/core-ktx/src/androidTest/java/androidx/core/view/ViewTest.kt
M fragment/fragment-ktx/api/restricted_current.txt
M navigation/navigation-safe-args-gradle-plugin/src/test/kotlin/androidx/navigation/safeargs/gradle/KotlinPluginTest.kt
M room/compiler/src/test/kotlin/androidx/room/processor/ProjectionExpanderTest.kt
M gradle.properties
M viewpager2/viewpager2/src/androidTest/java/androidx/viewpager2/widget/MutableCollectionsTest.kt
M recyclerview/recyclerview/src/androidTest/java/androidx/recyclerview/widget/LinearLayoutManagerRemoveShownItemsTest.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/BooksDaoTest.kt
M camera/integration-tests/camerapipetestapp/src/main/java/androidx/camera/integration/camera2/pipe/SimpleCamera.kt
M paging/common/src/test/kotlin/androidx/paging/CachingTest.kt
M fragment/fragment-ktx/src/main/java/androidx/fragment/app/Fragment.kt
M camera/integration-tests/timingtestapp/src/main/java/androidx/camera/integration/antelope/CameraUtils.kt
D fragment/fragment-ktx/src/main/java/androidx/fragment/app/FragmentResultOwner.kt
M dynamic-animation/dynamic-animation-ktx/api/public_plus_experimental_current.txt
M room/compiler/src/test/kotlin/androidx/room/ext/ElementExtTest.kt

https://android-review.googlesource.com/1399323

Issue 165300826

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Aug 27, 2020 08:30PM

pa...@google.com <pa...@google.com> #3Sep 3, 2020 11:26AM

ap...@google.com <ap...@google.com> #4Nov 29, 2021 01:37AM

Add comment

Issue metadata