Fixed

Bug

Status Update

No update yet.

Description

xz...@gmail.com

created issue #1

Aug 20, 2020 07:27AM

Description of the issue

When using a VerticalGridView with a ConcatAdapter, the focus jumps when passing from an element from one sub-adapter to an element from the other sub-adapter.

E.g.:

Adapter 1 = 2 elements
Adapter 2 = 15 elements

Focus is on element 0 (Element 0 of Adapter 1)
I press the DPAD down
Focus is on element 1 (Element 1 of Adapter 1)
I press the DPAD down
Focus is on element 4 (Element 2 of Adapter 2)
I press the DPAD up
Focus is on element 3 (Element 1 of Adapter 2)
I press the DPAD up
Focus is on element 2 (Element 0 of Adapter 2)
I press the DPAD up
Focus is on element 0 (Element 0 of Adapter 1)

A recording of this can be found here: ConcatAdapter_bug_on_Android_TV.mp4.

Component used

LeanBack: 1.1.0-alpha04 (I had the same behavior with 1.0.0 though)
RecyclerView: 1.2.0-alpha05

Devices/Android versions reproduced on

Any Android TV

Sample project

https://gist.github.com/bmonjoie/6ceb2965834bc22ef78be8ca8ddae969

Comments

da...@google.com <da...@google.com> #2Aug 25, 2020 04:53PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

xz...@gmail.com <xz...@gmail.com> #3Aug 26, 2020 07:00AM

Can you please try this link?

xz...@gmail.com <xz...@gmail.com> #4Aug 26, 2020 07:16AM

Our team investigated that the issue is caused by a change in the RecyclerView library.

The now deprecated methods RecyclerView.ViewHolder.getAdapterPosition() and RecyclerView.LayoutParams.getViewAdapterPosition() fall back to calling RecyclerView.ViewHolder.getBindingAdapterPosition() instead of RecyclerView.ViewHolder.getAbsoluteAdapterPosition().

Leanback depends on the fact that getAdapterPosition() returns a unique position for the RecyclerView, which is no longer the case if you use a ConcatAdapter.

xz...@gmail.com <xz...@gmail.com> #5Sep 21, 2020 02:44PM

Hi, any news regarding this issue?

da...@google.com <da...@google.com> Sep 21, 2020 06:01PM

Accepted by da...@google.com.

ap...@google.com <ap...@google.com> #6Sep 21, 2020 10:04PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 2b6777f6f3d8d8015150dfb17b04ade6f1932b0e
Author: Dake Gu <dake@google.com>
Date: Mon Sep 21 12:33:16 2020

leanback: fix ConcatAdapter

The widget should only care about item's getAbosoluteAdapterPosition.

Also fixed flaky GridWidgetTest.scroll(), sometimes it didn't scroll to
begin/end of the screen.

Test: GridWidgetTest.testConcat
Bug: 165694295
Change-Id: Idb70ec00aae74170425a8628290cd604934259c4

M leanback/leanback/src/androidTest/java/androidx/leanback/widget/GridActivity.java
M leanback/leanback/src/androidTest/java/androidx/leanback/widget/GridWidgetTest.java
M leanback/leanback/src/main/java/androidx/leanback/widget/GridLayoutManager.java

https://android-review.googlesource.com/1433120

da...@google.com <da...@google.com> #7Sep 25, 2020 08:47PM

Marked as fixed.

Expect to be release in upcoming release in about one week

IssueTracker

ConcatAdapter doesn't play well with VerticalGridView

Status Update

Description

Description of the issue

Component used

Devices/Android versions reproduced on

Sample project

Comments

da...@google.com <da...@google.com> #2Aug 25, 2020 04:53PM

xz...@gmail.com <xz...@gmail.com> #3Aug 26, 2020 07:00AM

xz...@gmail.com <xz...@gmail.com> #4Aug 26, 2020 07:16AM

xz...@gmail.com <xz...@gmail.com> #5Sep 21, 2020 02:44PM

da...@google.com <da...@google.com> Sep 21, 2020 06:01PM

ap...@google.com <ap...@google.com> #6Sep 21, 2020 10:04PM

da...@google.com <da...@google.com> #7Sep 25, 2020 08:47PM

Issue 165694295

Description

Description of the issue

Component used

Devices/Android versions reproduced on

Sample project

Issue summary

Comments

da...@google.com <da...@google.com> #2Aug 25, 2020 04:53PM

xz...@gmail.com <xz...@gmail.com> #3Aug 26, 2020 07:00AM

xz...@gmail.com <xz...@gmail.com> #4Aug 26, 2020 07:16AM

xz...@gmail.com <xz...@gmail.com> #5Sep 21, 2020 02:44PM

da...@google.com <da...@google.com> Sep 21, 2020 06:01PM

ap...@google.com <ap...@google.com> #6Sep 21, 2020 10:04PM

da...@google.com <da...@google.com> #7Sep 25, 2020 08:47PM

Add comment

Issue metadata