[Paging 3] Fatal Exception: java.lang.IndexOutOfBoundsException [165821814]

Fixed

Bug

Status Update

No update yet.

Description

ke...@gmail.com

created issue #1

Aug 21, 2020 03:47AM

Component used: Paging 3
Version used: 3.0.0-alpha05
Devices/Android versions reproduced on: any

I am using GridLayoutManager with 3rd party fast scrollbar, and my Room paging source has more then 200,000 rows (enable placeholder in PagingConfig), when I scroll my recyclerview back and forth, app crash.

Fatal Exception: java.lang.IndexOutOfBoundsException: Index: 1, Size: 1
at java.util.ArrayList.get(ArrayList.java:437)
at androidx.paging.PageFetcherSnapshot.currentPagingState(PageFetcherSnapshot.kt:691)
at androidx.paging.PageFetcherSnapshot.doInitialLoad(PageFetcherSnapshot.kt:378)
at androidx.paging.PageFetcherSnapshot$doInitialLoad$1.invokeSuspend(:12)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:56)
at android.os.Handler.handleCallback(Handler.java:883)
at android.os.Handler.dispatchMessage(Handler.java:100)
at android.os.Looper.loop(Looper.java:359)
at android.app.ActivityThread.main(ActivityThread.java:7418)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:935)

Comments

du...@google.com <du...@google.com> #2Aug 21, 2020 06:21PM

Any updates on when we can expect RxJava 3 support in the androidx.paging library? It looks like some of the other androidx libraries already support it. Example

https://android-review.googlesource.com/c/platform/frameworks/support/+/1277904

du...@google.com <du...@google.com> #3Aug 21, 2020 06:25PM

We're working on it!

https://android-review.googlesource.com/c/platform/frameworks/support/+/1355043

ke...@gmail.com <ke...@gmail.com> #4Aug 22, 2020 12:31PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 83b0d9c4c606cc5d5aa86eef303ceb538367ad9f
Author: Zac Sweers <pandanomic@gmail.com>
Date: Fri Jul 03 00:22:37 2020

Add paging-rxjava3 artifact

This adds an rxjava3 extensions artifact for paging v3. It's ported from the rx2 artifact, but with all the deprecated APIs from that artifact removed.

I had to update the coroutines version to 1.3.7 (technically 1.3.6 was when it was introduced, but with a serious issue affecting android lint that is fixed in 1.3.7). I don't know how to get those prebuilts updates included in my CL though, not sure if it's necessary. Let me know.

RelNote: "Add RxJava3 compatibility wrappers for PagingSource and
RemoteMediator"
Fixes: 161480176
Test: ./gradlew paging:paging-rxjava3:test

Change-Id: I49ef38fde9b84f92dd272ed0b1cd1719fbbf1761

M buildSrc/build_dependencies.gradle
M buildSrc/src/main/kotlin/androidx/build/PublishDocsRules.kt
M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
A paging/rxjava3/api/3.0.0-alpha04.txt
A paging/rxjava3/api/current.txt
A paging/rxjava3/api/public_plus_experimental_3.0.0-alpha04.txt
A paging/rxjava3/api/public_plus_experimental_current.txt
A paging/rxjava3/api/res-3.0.0-alpha04.txt
A paging/rxjava3/api/res-current.txt
A paging/rxjava3/api/restricted_3.0.0-alpha04.txt
A paging/rxjava3/api/restricted_current.txt
A paging/rxjava3/build.gradle
A paging/rxjava3/src/main/AndroidManifest.xml
A paging/rxjava3/src/main/java/androidx/paging/rxjava3/PagingRx.kt
A paging/rxjava3/src/main/java/androidx/paging/rxjava3/RxPagingSource.kt
A paging/rxjava3/src/main/java/androidx/paging/rxjava3/RxRemoteMediator.kt
A paging/rxjava3/src/test/java/androidx/paging/RxPagingSourceTest.kt
A paging/rxjava3/src/test/java/androidx/paging/RxRemoteMediatorTest.kt
M settings.gradle

https://android-review.googlesource.com/1355043

du...@google.com <du...@google.com> #5Aug 24, 2020 08:48PM

Noting for the future, this is due to a race between presenter state and currentPagingState in fetcher-side. We need to resolve state-mismatch for in-flight events by estimating using pageSize.

wip fix here for those interested in following: https://android-review.googlesource.com/c/platform/frameworks/support/+/1406499

ke...@gmail.com <ke...@gmail.com> #6Aug 26, 2020 06:44AM

thanks for quick reply

[Deleted User] <[Deleted User]> #7Aug 26, 2020 01:03PM

I have the similar problem too even I don't use a fast scrollbar. This issue seems to randomly happends. Hoping the next realease will be good again.

du...@google.com <du...@google.com> Sep 3, 2020 06:54AM

Accepted by du...@google.com.

ap...@google.com <ap...@google.com> #8Sep 21, 2020 07:37PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 52413b0b4f046941c705cda6fd794744c1610704
Author: Dustin Lam <dustinlam@google.com>
Date: Fri Aug 21 18:14:29 2020

Handle races between presenter and fetcher when creating PagingState

In cases where fetcher and presenter state race, calling generating
PagingState can crash due to the fetcher assuming hint values, which are
base on presenter state are up-to-date. To account for this, we adjust
anchorPosition by estimating using PagingConfig.pageSize.

Relnote: "Fixed IndexOutOfBounds exception thrown in RemoteMediator due
to a race condition."
Test: ./gradlew paging:paging-common:test
Fixes: 165821814
Change-Id: I00b7f9b00b2a36395ba8fe5c77931fec3ce20d7a

M paging/common/src/main/kotlin/androidx/paging/PageFetcherSnapshot.kt
M paging/common/src/main/kotlin/androidx/paging/PageFetcherSnapshotState.kt
M paging/common/src/main/kotlin/androidx/paging/PagingState.kt
M paging/common/src/main/kotlin/androidx/paging/ViewportHint.kt
M paging/common/src/test/kotlin/androidx/paging/PageFetcherSnapshotStateTest.kt
M paging/common/src/test/kotlin/androidx/paging/PageFetcherSnapshotTest.kt

https://android-review.googlesource.com/1417532