[Paging 3] Fatal Exception: java.lang.IndexOutOfBoundsException [165821814]

Fixed

Bug

Status Update

No update yet.

Description

ke...@gmail.com

created issue #1

Aug 21, 2020 03:47AM

Component used: Paging 3
Version used: 3.0.0-alpha05
Devices/Android versions reproduced on: any

I am using GridLayoutManager with 3rd party fast scrollbar, and my Room paging source has more then 200,000 rows (enable placeholder in PagingConfig), when I scroll my recyclerview back and forth, app crash.

Fatal Exception: java.lang.IndexOutOfBoundsException: Index: 1, Size: 1
at java.util.ArrayList.get(ArrayList.java:437)
at androidx.paging.PageFetcherSnapshot.currentPagingState(PageFetcherSnapshot.kt:691)
at androidx.paging.PageFetcherSnapshot.doInitialLoad(PageFetcherSnapshot.kt:378)
at androidx.paging.PageFetcherSnapshot$doInitialLoad$1.invokeSuspend(:12)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:56)
at android.os.Handler.handleCallback(Handler.java:883)
at android.os.Handler.dispatchMessage(Handler.java:100)
at android.os.Looper.loop(Looper.java:359)
at android.app.ActivityThread.main(ActivityThread.java:7418)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:935)

Comments

du...@google.com <du...@google.com> #2Aug 21, 2020 06:21PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

du...@google.com <du...@google.com> #3Aug 21, 2020 06:25PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

ke...@gmail.com <ke...@gmail.com> #4Aug 22, 2020 12:31PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

du...@google.com <du...@google.com> #5Aug 24, 2020 08:48PM

Noting for the future, this is due to a race between presenter state and currentPagingState in fetcher-side. We need to resolve state-mismatch for in-flight events by estimating using pageSize.

wip fix here for those interested in following: https://android-review.googlesource.com/c/platform/frameworks/support/+/1406499

ke...@gmail.com <ke...@gmail.com> #6Aug 26, 2020 06:44AM

thanks for quick reply

[Deleted User] <[Deleted User]> #7Aug 26, 2020 01:03PM

I have the similar problem too even I don't use a fast scrollbar. This issue seems to randomly happends. Hoping the next realease will be good again.

du...@google.com <du...@google.com> Sep 3, 2020 06:54AM

Accepted by du...@google.com.

ap...@google.com <ap...@google.com> #8Sep 21, 2020 07:37PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 52413b0b4f046941c705cda6fd794744c1610704
Author: Dustin Lam <dustinlam@google.com>
Date: Fri Aug 21 18:14:29 2020

Handle races between presenter and fetcher when creating PagingState

In cases where fetcher and presenter state race, calling generating
PagingState can crash due to the fetcher assuming hint values, which are
base on presenter state are up-to-date. To account for this, we adjust
anchorPosition by estimating using PagingConfig.pageSize.

Relnote: "Fixed IndexOutOfBounds exception thrown in RemoteMediator due
to a race condition."
Test: ./gradlew paging:paging-common:test
Fixes: 165821814
Change-Id: I00b7f9b00b2a36395ba8fe5c77931fec3ce20d7a

M paging/common/src/main/kotlin/androidx/paging/PageFetcherSnapshot.kt
M paging/common/src/main/kotlin/androidx/paging/PageFetcherSnapshotState.kt
M paging/common/src/main/kotlin/androidx/paging/PagingState.kt
M paging/common/src/main/kotlin/androidx/paging/ViewportHint.kt
M paging/common/src/test/kotlin/androidx/paging/PageFetcherSnapshotStateTest.kt
M paging/common/src/test/kotlin/androidx/paging/PageFetcherSnapshotTest.kt

https://android-review.googlesource.com/1417532