Missing support for compound drawables tint [165822337]

Fixed

Feature Request

Status Update

No update yet.

Description

kf...@gmail.com

created issue #1

Aug 21, 2020 09:28AM

Component used: androidx.appcompat:appcompat:1.2.0
Version used: 1.2.0
Devices/Android versions reproduced on: Any

Support for compound drawables tint has been added to the following TextView subclasses:
- AppCompatButton
- AppCompatTextView

However it is still missing in the following TextView subclasses:
- AppCompatAutoCompleteTextView
- AppCompatCheckBox
- AppCompatCheckedTextView
- AppCompatEditText
- AppCompatMultiAutoCompleteTextView
- AppCompatRadioButton
- AppCompatToggleButton

They just need to implement TintableCompoundDrawablesView and delegate the implementation to AppCompatTextHelper.

Comments

ki...@google.com <ki...@google.com> Dec 7, 2020 04:55PM

Reassigned to al...@google.com.

yu...@gmail.com <yu...@gmail.com> #2Sep 1, 2021 07:31AM

With the change of lifecycle-common to KMP, we might be able to just move this into the right spot (since it'll mirror the same structure as lifecycle-runtime, which does work).

al...@google.com <al...@google.com> #3Jan 6, 2022 06:12PM

lifecycle-common even after conversion to KMP is still a jar. We do not want to change that to an AAR as that is a breaking change for consumers, so i dont think we can make it work this project.

al...@google.com <al...@google.com> Feb 11, 2022 08:29PM

Accepted by al...@google.com.

ap...@google.com <ap...@google.com> #4Feb 17, 2022 06:44PM

Marked as fixed.

Ah yeah good point.

al...@google.com <al...@google.com> #5Feb 17, 2022 08:40PM

Project: platform/frameworks/support
Branch: androidx-main

commit a00e293b59bdbe5746941171fe793b863aaafabe
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Apr 11 15:42:42 2024

Move baseline-prof.txt from Lifecycle common to runtime

* Move `baseline-prof.txt` from `lifecycle-common` to `lifecycle-runtime`;
* Because there are multiple files now in `lifecycle-runtime`, group them inside a `baselineProfiles` folder.
* Rename the files to match what modules they target.

Test: N/A
Fixes: 322382422
Change-Id: Iaced653d78e6fe6c107e389ed76cd3ca37e46347

D lifecycle/lifecycle-common/src/jvmMain/baseline-prof.txt
M lifecycle/lifecycle-runtime/build.gradle
M lifecycle/lifecycle-runtime/src/androidMain/baseline-prof.txt

https://android-review.googlesource.com/3038274

Issue 165822337