Missing support for compound drawables tint [165822337]

Fixed

Feature Request

Status Update

No update yet.

Description

kf...@gmail.com

created issue #1

Aug 21, 2020 09:28AM

Component used: androidx.appcompat:appcompat:1.2.0
Version used: 1.2.0
Devices/Android versions reproduced on: Any

Support for compound drawables tint has been added to the following TextView subclasses:
- AppCompatButton
- AppCompatTextView

However it is still missing in the following TextView subclasses:
- AppCompatAutoCompleteTextView
- AppCompatCheckBox
- AppCompatCheckedTextView
- AppCompatEditText
- AppCompatMultiAutoCompleteTextView
- AppCompatRadioButton
- AppCompatToggleButton

They just need to implement TintableCompoundDrawablesView and delegate the implementation to AppCompatTextHelper.

Comments

ki...@google.com <ki...@google.com> Dec 7, 2020 04:55PM

Reassigned to al...@google.com.

yu...@gmail.com <yu...@gmail.com> #2Sep 1, 2021 07:31AM

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

al...@google.com <al...@google.com> #3Jan 6, 2022 06:12PM

Great! Thanks a lot, I'll look for the live updates soon!

al...@google.com <al...@google.com> Feb 11, 2022 08:29PM

Accepted by al...@google.com.

ap...@google.com <ap...@google.com> #4Feb 17, 2022 06:44PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 5184652d714e2f13390a9ff6884d8e4bd41d0f8e
Author: Alan Viverette <alanv@google.com>
Date: Tue Feb 08 16:13:05 2022

Implement TintableCompoundDrawablesView in TextView-derived widgets

Adds AppCompatMultiAutoCompleteViewTest, which is a direct copy of
AppCompatAutoCompleteViewTest. Everything else is copied from
AppCompatTextView and refactored to match the class names. There's no
new logic in this CL.

Relnote: Backports compound drawable tinting to TextView-derived widgets
Fixes: 165822337
Test: AppCompatCheckBoxTest, etc.
Change-Id: Idf98ced324a724a5cb5b9d5a2f397a3b82fad900

M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatMultiAutoCompleteTextView.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatCheckBox.java
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatAutoCompleteTextViewTest.java
M appcompat/appcompat/src/androidTest/res/layout/appcompat_togglebutton_activity.xml
M appcompat/appcompat/api/restricted_current.txt
M appcompat/appcompat/src/androidTest/AndroidManifest.xml
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatCheckBoxTest.java
M appcompat/appcompat/src/androidTest/res/layout/appcompat_autocompletetextview_activity.xml
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatRadioButton.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatEditText.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatAutoCompleteTextView.java
A appcompat/appcompat/src/androidTest/res/layout/appcompat_multiautocompletetextview_activity.xml
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatEditTextTest.java
M appcompat/appcompat/api/current.txt
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatToggleButton.java
A appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatMultiAutoCompleteTextViewTest.java
M appcompat/appcompat/api/public_plus_experimental_current.txt
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatToggleButtonTest.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatCheckedTextView.java
A appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatMultiAutoCompleteTextViewActivity.java
M appcompat/appcompat/src/androidTest/res/layout/appcompat_checkedtextview_activity.xml
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatCheckedTextViewTest.java
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatRadioButtonTest.java
M appcompat/appcompat/src/androidTest/res/layout/appcompat_checkbox_activity.xml
M appcompat/appcompat/src/androidTest/res/layout/appcompat_edittext_activity.xml
M appcompat/appcompat/src/androidTest/res/layout/appcompat_radiobutton_activity.xml

https://android-review.googlesource.com/1978467

al...@google.com <al...@google.com> #5Feb 17, 2022 08:40PM

This is one of those cases where I am so glad that we have good tests. It's surprising how much can go wrong in a straightforward* copy/paste set of changes.

Anyway, this won't be in the next release -- just missed build cut deadline -- but it'll be out in a 1.5.0 alpha some time in the next ~month.

*actually not straightforward

Issue 165822337