Fixed
Status Update
Comments
nj...@google.com <nj...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit ece1e0ac47be4572d97afef494a24827c014af57
Author: Nader Jawad <njawad@google.com>
Date: Mon Aug 24 20:47:20 2020
Fixed wrong constructor parameter order for Rect
Relnote: "Fixed issue where Rect function constructor
with Offset and radius would create the Rect in the
order of left, right, top, bottom instead of
left, top, right, bottom.
Removed deprecated companion methods on Rect in
favor of function constructors.
Added tests to verify methods in Rect.kt"
Change-Id: I0846006bd0ec7f1a0effd90490c93002b42e132b
Fixes: 165822356
Test: Added tests to RectTest
M compose/ui/ui-geometry/api/current.txt
M compose/ui/ui-geometry/api/public_plus_experimental_current.txt
M compose/ui/ui-geometry/api/restricted_current.txt
M compose/ui/ui-geometry/src/commonMain/kotlin/androidx/compose/ui/geometry/Rect.kt
M compose/ui/ui-geometry/src/test/kotlin/androidx/compose/ui/geometry/RectTest.kt
https://android-review.googlesource.com/1409488
Branch: androidx-master-dev
commit ece1e0ac47be4572d97afef494a24827c014af57
Author: Nader Jawad <njawad@google.com>
Date: Mon Aug 24 20:47:20 2020
Fixed wrong constructor parameter order for Rect
Relnote: "Fixed issue where Rect function constructor
with Offset and radius would create the Rect in the
order of left, right, top, bottom instead of
left, top, right, bottom.
Removed deprecated companion methods on Rect in
favor of function constructors.
Added tests to verify methods in Rect.kt"
Change-Id: I0846006bd0ec7f1a0effd90490c93002b42e132b
Fixes: 165822356
Test: Added tests to RectTest
M compose/ui/ui-geometry/api/current.txt
M compose/ui/ui-geometry/api/public_plus_experimental_current.txt
M compose/ui/ui-geometry/api/restricted_current.txt
M compose/ui/ui-geometry/src/commonMain/kotlin/androidx/compose/ui/geometry/Rect.kt
M compose/ui/ui-geometry/src/test/kotlin/androidx/compose/ui/geometry/RectTest.kt
Description
Constructing a rect using center offset and radius seems to have wrong constructor params' order. The rect edges should be described in order: left, top, right, bottom.
Compose version: 0.1.0-dev17
Build: AI-201.7846.76.42.6720134, 202007292115,
AI-201.7846.76.42.6720134, JRE 1.8.0_242-release-1644-b01x64 JetBrains s.r.o, OS Windows 10(amd64) v10.0 , screens 1920x1080
AS: 4.2 Canary 7; Kotlin plugin: 1.4.0-release-Studio4.1-1; Android Gradle Plugin: 4.2.0-alpha07; Gradle: 6.5; NDK: from local.properties: (not specified), latest from SDK: 21.2.6472646; LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: (not found)