Wrong constructor parameter's order when constructing a Rect [165822356]

Fixed

Bug

Status Update

No update yet.

Description

pw...@gmail.com

created issue #1

Aug 22, 2020 02:13PM

Constructing a rect using center offset and radius seems to have wrong constructor params' order. The rect edges should be described in order: left, top, right, bottom.

/**
 * Construct a rectangle that bounds the given circle
 * @param center Offset that represents the center of the circle
 * @param radius Radius of the circle to enclose
 */
@Stable
fun Rect(center: Offset, radius: Float): Rect =
    Rect(
        center.x - radius,
        center.x + radius,
        center.y - radius,
        center.y + radius
    )

Compose version: 0.1.0-dev17

Build: AI-201.7846.76.42.6720134, 202007292115,

AI-201.7846.76.42.6720134, JRE 1.8.0_242-release-1644-b01x64 JetBrains s.r.o, OS Windows 10(amd64) v10.0 , screens 1920x1080

AS: 4.2 Canary 7; Kotlin plugin: 1.4.0-release-Studio4.1-1; Android Gradle Plugin: 4.2.0-alpha07; Gradle: 6.5; NDK: from local.properties: (not specified), latest from SDK: 21.2.6472646; LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: (not found)

Comments

nj...@google.com <nj...@google.com> Aug 24, 2020 04:37AM

Assigned to nj...@google.com.

ap...@google.com <ap...@google.com> #2Aug 25, 2020 04:04PM

Marked as fixed.

just query LocalView instead of setting this metadata at the ComposeView layer to unblock the most common cases.

As we can't know when / if the ComposeView is moved to a different part of the View hierarchy, we don't have a good callback / place to update this value within ComposeView - theoretically since shouldDelayChildPressedState is a function, it could return different values at different points in time in any case. So we should instead continue to query the view hierarchy during a press, to see if at that point in time we should delay the press or not.

So instead we just need to provide whether there is a scrollable Compose node, and then consumers can combine querying that with whether there is a scrollable ViewGroup, to work out whether they should delay presses or not. AndroidView can solely query whether it is in a scrollable Compose node, as anything inside it will look up the view hierarchy anyway

Issue 165822356

Description

Issue summary

Comments

nj...@google.com <nj...@google.com> Aug 24, 2020 04:37AM

ap...@google.com <ap...@google.com> #2Aug 25, 2020 04:04PM

Add comment

Issue metadata