Wrong constructor parameter's order when constructing a Rect [165822356]

Fixed

Bug

Status Update

No update yet.

Description

pw...@gmail.com

created issue #1

Aug 22, 2020 02:13PM

Constructing a rect using center offset and radius seems to have wrong constructor params' order. The rect edges should be described in order: left, top, right, bottom.

/**
 * Construct a rectangle that bounds the given circle
 * @param center Offset that represents the center of the circle
 * @param radius Radius of the circle to enclose
 */
@Stable
fun Rect(center: Offset, radius: Float): Rect =
    Rect(
        center.x - radius,
        center.x + radius,
        center.y - radius,
        center.y + radius
    )

Compose version: 0.1.0-dev17

Build: AI-201.7846.76.42.6720134, 202007292115,

AI-201.7846.76.42.6720134, JRE 1.8.0_242-release-1644-b01x64 JetBrains s.r.o, OS Windows 10(amd64) v10.0 , screens 1920x1080

AS: 4.2 Canary 7; Kotlin plugin: 1.4.0-release-Studio4.1-1; Android Gradle Plugin: 4.2.0-alpha07; Gradle: 6.5; NDK: from local.properties: (not specified), latest from SDK: 21.2.6472646; LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: (not found)

Comments

nj...@google.com <nj...@google.com> Aug 24, 2020 04:37AM

Assigned to nj...@google.com.

ap...@google.com <ap...@google.com> #2Aug 25, 2020 04:04PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 0154910724cdc44253af1d2f8cede76264783226
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Idfd1faa3a826bb91ee14722f7437bdcf99cf0018

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt

https://android-review.googlesource.com/3151736

Issue 165822356

Description

Issue summary

Comments

nj...@google.com <nj...@google.com> Aug 24, 2020 04:37AM

ap...@google.com <ap...@google.com> #2Aug 25, 2020 04:04PM

Add comment

Issue metadata