LazyColumn and animateContentSize or AnimatedVisibility issue [165921895]

Fixed

Bug

Status Update

No update yet.

Description

mo...@gmail.com

created issue #1

Aug 22, 2020 01:26PM

The compose which i apply animateContentSize or AnimatedVisibility seems to disappear on scrolling up but when i click on it it appears again.
The scrolling is laggy also.

Android Studio Build: Canary 7
Version of Gradle Plugin: 4.2.0-alpha07
Version of Gradle: 6.6-rc-3-all
Version of Java: 1.8
OS: Windows 10

Steps to Reproduce: Gist to reproduce

https://gist.github.com/mohamedmelfiky/4f1d9feeff8a8678a9f0f69dbbb73660
There is also videos for the issue on a slack thread in compose channel

https://kotlinlang.slack.com/archives/CJLTWPH7S/p1598000409046800

The example uses AnimatedVisibility but before that i used animateContentSize and same thing happen

Comments

ti...@google.com <ti...@google.com> Aug 22, 2020 05:26PM

Assigned to ti...@google.com.

ti...@google.com <ti...@google.com> #2Aug 22, 2020 06:59PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b2ae0a8c9429e6def582fda75e85f76540a31192
Author: Ralston Da Silva <ralu@google.com>
Date: Thu Jul 09 18:55:04 2020

New Focus Modifier Implementation

This is the first CL in a series of CLs which implement the new focus API. The new implementation consists of multiple modifiers each implementing a specific use case.
This CL adds FocusModifier2 and ModifiedFocusNode2 (Which will be renamed to FocusModifier and ModifiedFocusNode after the existing classes are deleted).

Bug: 160924778
Relnote: Added Modifier.focus which replaces FocusModifier.
Test: Built and launched the demo app
Change-Id: Ib852a056a0f3c76757f0fdef07e75e82bf178b8d

M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/DelegatingLayoutNodeWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/InnerPlaceable.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/LayoutNodeWrapper.kt
A ui/ui-core/src/commonMain/kotlin/androidx/ui/core/focus/FocusModifier2.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/focus/FocusNodeUtils.kt
A ui/ui-core/src/commonMain/kotlin/androidx/ui/core/focus/ModifiedFocusNode2.kt

https://android-review.googlesource.com/1359576

ti...@google.com <ti...@google.com> #3Aug 22, 2020 07:13PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 79b361fcb1a863005e834f70a88cae274f6ca3ce
Author: Ralston Da Silva <ralu@google.com>
Date: Mon Jul 13 18:34:14 2020

Instantiate a ModifiedFocusNode2 corresponding to a Modifier.focus() modifier

Bug: 160924778
Test: Built and launched the demo app
Change-Id: Ib5e045621e36a72327acf148bb1698632ffe182f

M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/LayoutNode.kt

https://android-review.googlesource.com/1362065

device-2020-08-22-120735.png

101 KB

View

Download

an...@google.com <an...@google.com> #4Aug 27, 2020 04:51PM

Reassigned to an...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a52a858283c3ee5af05036e1e3665784a3051f4f
Author: Ralston Da Silva <ralu@google.com>
Date: Mon Jul 13 18:19:31 2020

Add a modifier to request focus changes

Bug: 161182057, 160924778
Relnote: Added a modifier to request focus changes
Test: Built and launched the demo App.
Change-Id: I8dd73cf3ce77e112a9f97f203b8ec7a0f07bc706

M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/LayoutNode.kt
A ui/ui-core/src/commonMain/kotlin/androidx/ui/core/focus/FocusRequester.kt
A ui/ui-core/src/commonMain/kotlin/androidx/ui/core/focus/FocusRequesterModifier.kt
A ui/ui-core/src/commonMain/kotlin/androidx/ui/core/focus/ModifiedFocusRequesterNode.kt

https://android-review.googlesource.com/1362064

ti...@google.com <ti...@google.com> #5Aug 27, 2020 05:26PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c8c1ab4e79928727f722e5c946c7342dd9fa30f8
Author: Ralston Da Silva <ralu@google.com>
Date: Wed Jul 15 01:20:27 2020

Instantiate a ModifiedFocusNode2 corresponding to a Modifier.focus() modifier

Bug: 160924778
Test: Built and launched the demo app
Change-Id: Ide2b07ec55b65627d1a8cfedef55848807537bac

M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/LayoutNode.kt

https://android-review.googlesource.com/1363337

ap...@google.com <ap...@google.com> #6Sep 9, 2020 03:48PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 308929cf794a4e3cb1c1adca86bc62ee32ad1613
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Thu Sep 03 17:07:40 2020

Fix crash and items of LazyColumn being incorrectly drawn

If the child LayoutNode was not placed its layers invalidation is still scheduled and we ended up drawing not measured node or just drawing the incorrect state of the node. And then we didn't redraw it correctly next time when the parent finally placed the node as it was already invalidated and not dirty anymore.

Test: InvalidatingNotPlacedChildTest, manually
Relnote: Fix for items of LazyColumn being incorrectly drawn sometimes, this was also causing crashes in some conditions.
Fixes: 163066980
Fixes: 165921895
Change-Id: Ibcf1745e40606f6a38d9eb90f915443935d34403

A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/InvalidatingNotPlacedChildTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/InnerPlaceable.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayerWrapper.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt

https://android-review.googlesource.com/1419311

Issue 165921895