Status Update
Comments
yi...@google.com <yi...@google.com> #2
First of all thanks for this detailed issue.
This issue had been investigated thoroughly when it was first reported internally. The surprising detail in this report is that the issue is not reproducible before 1.7
. I will look into this.
The main problem with POBox is the fact that it is deprecated. Since 2021 Sony has been shipping new Xperia devices with Gboard pre-installed. Although we are aware that there is still a considerable amount of users still using POBox, the described behavior is caused by POBox's noncompliant behavior with InputConnection
and InputMethodManager
documentation. However, this is understandable since TextView
implementation was also not respecting the behavior that is expected from Editors.
Ultimately we have decided to enforce the documented behavior with specifically regards to when editors should call InputMethodManager.updateSelection
. Also, although unconfirmed, there were traces of possible custom code being included in Sony OEM images that changed how InputMethodManager was notified from TextView. If POBox also depended on something like this, it would be impossible for Compose code to replicate the same unknown behavior.
pa...@google.com <pa...@google.com> #3
Or is that option not available?
Even if the root cause is POBox, from the perspective of the app's customers, it looks like an app bug, so this issue is a blocker against updating Jetpack Compose.
pa...@google.com <pa...@google.com> #4
Just to be sure, it is dangerous to replace Compose TextField with Android View EditText as a workaround for this issue.
Compose 1.7 has a bug that causes ANR when the focus is on EditText.
Another View-related bug in Compose 1.7 is that an Android View is focused by calling FocusManager.clearFocus().
Perhaps there is a lack of testing of Compose 1.7 in combination with Android View. There is also a possibility that there are other fatal bugs related to View.
In other words, the only options for apps targeting the Japanese market that require POBox support are to continue using Compose 1.6 or to use EditText in combination with various workarounds.
si...@google.com <si...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
Author: Halil Ozercan <
Link:
Fix POBox keyboard issue
Expand for full commit details
Fix POBox keyboard issue
Fix: 373743376
Fix: 329209241
Test: NullableInputConnectionWrapperTest
Change-Id: I94e0e598274fb88b255f977f9fbd50dfbbb1ecb1
Files:
- M
compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapperTest.kt
- M
compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapper.android.kt
Hash: 57f58c4b80d5d8470b2aca325dfdcd55f235231e
Date: Thu Oct 24 01:25:20 2024
yi...@google.com <yi...@google.com> #6
Many thanks again for this report. Especially for giving us a huge clue in terms of what could be going wrong. The fix is now merged and I will ask for a cherry-pick into a stable release.
ap...@google.com <ap...@google.com> #7
Do you have any concrete plan to cherry-pick the fix into current stable version (1.7.x)? We are currently waiting it.
yi...@google.com <yi...@google.com>
yi...@google.com <yi...@google.com> #8
Yes, this fix is planned to be included in a future 1.7.x
release.
cc...@google.com <cc...@google.com> #9
Thanks for the fix. Sorry to follow up on this. is it possible for you to share specific release version/date for the stable version? We are waiting on this to decide on our direction.
yi...@google.com <yi...@google.com> #10
So I suppose the benchmarks (at least the TextInColumnBenchmark#toggleRectangleColor_measure) have accessibility manage enabled.
From my current runs, I see the performance degradation is in AndroidAccessibilityDelegateCompatCompat, not in LayoutNodeWrapper (finding the outer semantics).
So it is the building semantic tree and sending too many events caused this.
cc...@google.com <cc...@google.com> #11
Can you try running a more minimal benchmark, and see if the accessibility manager is enabled? E.g. benchmark-benchmark
(note, not part of compose project, have to use frameworks/support/
)
I'm also curious if it's enabled in standard simple instrumentation tests out of the box (e.g. new empty project in studio, run test there).
pw...@google.com <pw...@google.com> #12
yi...@google.com <yi...@google.com> #13
Also, since this benchmark doesn't trigger any view construction, I need to manually log the accessibility manager which needs the context. I see two ways:
one is in ViewInflationBenchmark (
I'm not sure which is the correct one, but I can test both if I can run the benchmark correctly.
yi...@google.com <yi...@google.com> #14
@Test
fun testTwelveKeyInflate() {
val context: Context = activityRule.activity
val accessibilityManager: AccessibilityManager = context.getSystemService(Context
.ACCESSIBILITY_SERVICE) as AccessibilityManager
Log.v("yinglei", "accessibility manager basic ${accessibilityManager.isEnabled}")
val inflater = LayoutInflater.from(context)
val root = FrameLayout(context)
benchmarkRule.measureRepeated {
inflater.inflate(R.layout.twelve_key_entry, root, false)
}
}
The log shows accessibility manager is enabled
yi...@google.com <yi...@google.com> #15
cc...@google.com <cc...@google.com> #16
@Phil, you mention shell commands will enable the accessibility manager:
- Does that mean any shell commands called by any test infra will turn on the accessibility manager?
- What will stop the accessibility manager? Does it stay enabled until the process dies?
- Is it expected that turning this on will cause performance degradation (from additional accessibility work) in UIs, due to additional accessibility work?
@Yinglei - appcompat-benchmark
is good simple test case, likely indicates every benchmark would have accessibility manager enabled, then.
yi...@google.com <yi...@google.com> #17
I think we also want to measure performance with accessibility on for compose.
But for this bug, we do need to improve our accessibility code for performance.
pw...@google.com <pw...@google.com> #18
Since as you might imagine, I'm fine turning on accessibility, I've never looked into other ways of issuing shell commands. So your infrastructure may well be using another path. But if it created a UiAutomation, it turns on accessibility.
Description
Alert on dashboard:https://androidx-perf.skia.org/t/?begin=1598041363&end=1598041364&subset=all
CLs in build:https://android-build.googleplex.com/builds/6782628/branches/aosp-androidx-master-dev/targets/androidx/cls?end=6782525
Culprit: aosp/1384533