[TextField] Disabled text field [166478534]

Fixed

Feature Request

Status Update

No update yet.

Description

ni...@gmail.com

created issue #1

Aug 26, 2020 08:15PM

It is possible to make some of the form components disabled by passing enabled=false argument (Checkbox, RadioButton, Button), but unfortunately the same is impossible for the most basic form component - TextField

Comments

so...@google.com <so...@google.com> Aug 27, 2020 09:29AM

Reassigned to so...@google.com.

so...@google.com <so...@google.com> Sep 3, 2020 05:09PM

Accepted by so...@google.com.

tc...@google.com <tc...@google.com> #2Sep 18, 2020 09:53PM

Hi,

I also see my text cut off when I set maxLines = 2. Is it the same issue?

  Box(
    modifier =
      Modifier.size(
        width = 108dp,
        height = 34dp,
      ),
    contentAlignment = Alignment.Center,
  ) {
    BasicText(
      text = "text text text",
      maxLines = 2,
      autoSize = AutoSize.StepBased(minFontSize = 1.sp, maxFontSize = 13.sp, stepSize = 0.2.sp),
    )
  }

so...@google.com <so...@google.com> #3Sep 21, 2020 10:12AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jossi Wolf <jossiwolf@google.com>
Link: https://android-review.googlesource.com/3450389

Fix TextAutoSize bug with maxLines = 1

Expand for full commit details

Fix TextAutoSize bug with maxLines = 1 
 
We were overcaching the paragraphIntrinsics in MultiParagraphLayoutCache when mutating the style. For `AutoSizeStepBased` instances with biased windows (more values smaller/bigger than the optimal), this could result in performing layout with outdated intrinsics, and thus an outdated style and font size, without surfacing this in the TextLayoutResult. 
 
Test: New MultiParagraphLayoutCacheTests and manual testing 
Relnote: Fixed a bug in BasicText with TextAutoSize and maxLines set to 1. 
Fixes: 376834366 
 
Change-Id: Ic0450c763c5d764492995b44ee1fe570246a9689

Files:

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCacheTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCache.kt

Hash: e1b712d78cc60384ed67a56c006148291ba146a6
Date: Tue Jan 07 18:52:26 2025

vi...@hotmail.com <vi...@hotmail.com> #4Sep 29, 2020 05:36PM

#2, yeah, that's the same issue.

Message last modified on Sep 29, 2020 05:38PM

so...@google.com <so...@google.com> #5Sep 29, 2020 05:53PM

Thanks @jo...@google.com for fixing this! Do you know when the fix would be available for g3 apps?

si...@google.com <si...@google.com> #6Nov 5, 2020 05:35PM

Moving the internal discussion offline. The bug is fixed and the fix available in snapshot builds. We will comment on this issue when the bug fix is included in a release.

so...@google.com <so...@google.com> #7Nov 5, 2020 05:52PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-beta01
androidx.compose.foundation:foundation-android:1.8.0-beta01
androidx.compose.foundation:foundation-jvmstubs:1.8.0-beta01
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-beta01

si...@google.com <si...@google.com> #8Nov 5, 2020 06:13PM

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#htmlattrdefdisabled

si...@google.com <si...@google.com> #9Nov 5, 2020 06:30PM

tc...@google.com <tc...@google.com> #10Nov 11, 2020 05:37PM

Can you please confirm whether this made it into the latest release or update the iteration. Thanks!

so...@google.com <so...@google.com> #11Nov 11, 2020 06:07PM

Done.

ap...@google.com <ap...@google.com> #12Dec 24, 2020 07:47PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 18d398281228fd3c116553c608f45635fd3488ea
Author: Anastasia Soboleva <soboleva@google.com>
Date: Tue Dec 08 11:01:54 2020

Add support for disabled and read-only text fields

Bug: 171040474
Fixes: 166478534
Test: new tests
Relnote: "Added support for disabled and read-only text fields"
Change-Id: I352791811a7b75189013e1ed73c9834cfa5ce961

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/build.gradle
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/InactiveTextFieldTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/MaxLinesHeightModifierTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/SoftwareKeyboardTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldCursorTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldDefaultWidthTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldFocusTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldOnValueChangeTextFieldValueTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldScrollTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/BasicTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/InactiveTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/MaxLinesHeightModifier.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldScroll.kt
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialTextField.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/textfield/OutlinedTextFieldScreenshotTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/textfield/TextFieldScreenshotTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt

https://android-review.googlesource.com/1534463