Slice callback API null-ability mismatch [166489398]

Assigned

Bug

Status Update

No update yet.

Description

be...@gmail.com

created issue #1

Aug 27, 2020 10:04AM

Component used:

slices/view/src/main/java/androidx/slice/SliceViewManager.java
slices/core/src/main/java/androidx/slice/SliceProvider.java

Version used:

androidx.slice:slice-view:1.1.0-alpha01
androidx.slice:slice-core:1.1.0-alpha01

Devices/Android versions reproduced on:

Android 10 Emulators (API-29)

Bug

Using SliceViewManager.SliceCallback fails at runtime as the return type maybe null (Kotlin runtime null-check is failing!).

Reason

The callback interface SliceViewManager.SliceCallback is defined as SliceCallback.onSliceUpdated(@NonNull Slice s). That does not match as SliceProvider.onBindSlice is defined with @Nullable annotation[2]:

@Nullable
@RequiresApi(19)
public abstract Slice onBindSlice(@NonNull Uri sliceUri);

What is true? I think it should be nullable on both sides.

Regards

Benjamin E.

Comments

su...@google.com <su...@google.com> Aug 28, 2020 06:28PM

Reassigned to pi...@google.com.

ap...@google.com <ap...@google.com> #2Sep 2, 2020 10:14PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 1d85e1c78f22dba5e16c1741debf2a3913aebe9e
Author: Pinyao Ting <pinyaoting@google.com>
Date: Thu Aug 27 18:04:08 2020

Improves nullabilities in slice builder

Bug: 166489398
Relnote: Add nullabilities annotation in slice builders for better kotlin interop.
Test: run demo app and verify slices renders correctly
Change-Id: If00f14006017c097853a766c89f03f7530f1841d

M samples/SupportSliceDemos/src/main/java/com/example/androidx/slice/demos/SliceSelectionDialog.java
M slices/builders/api/current.txt
M slices/builders/api/public_plus_experimental_current.txt
M slices/builders/api/restricted_current.txt
M slices/builders/src/main/java/androidx/slice/builders/ListBuilder.java
M slices/builders/src/main/java/androidx/slice/builders/impl/GridRowBuilderListV1Impl.java
M slices/builders/src/main/java/androidx/slice/builders/impl/ListBuilder.java
M slices/builders/src/main/java/androidx/slice/builders/impl/ListBuilderBasicImpl.java
M slices/builders/src/main/java/androidx/slice/builders/impl/ListBuilderImpl.java
M slices/builders/src/main/java/androidx/slice/builders/impl/MessagingBasicImpl.java
M slices/builders/src/main/java/androidx/slice/builders/impl/MessagingListV1Impl.java
M slices/builders/src/main/java/androidx/slice/builders/impl/MessagingV1Impl.java
M slices/builders/src/main/java/androidx/slice/builders/impl/SelectionBuilderBasicImpl.java
M slices/builders/src/main/java/androidx/slice/builders/impl/SelectionBuilderImpl.java
M slices/builders/src/main/java/androidx/slice/builders/impl/SelectionBuilderListV2Impl.java
M slices/builders/src/main/java/androidx/slice/builders/impl/TemplateBuilderImpl.java
M slices/view/api/current.txt
M slices/view/api/public_plus_experimental_current.txt
M slices/view/api/restricted_current.txt
M slices/view/src/main/java/androidx/slice/SliceMetadata.java
M slices/view/src/main/java/androidx/slice/SliceViewManager.java
M slices/view/src/main/java/androidx/slice/SliceViewManagerCompat.java
M slices/view/src/main/java/androidx/slice/SliceViewManagerWrapper.java
M slices/view/src/main/java/androidx/slice/widget/SliceLiveData.java

https://android-review.googlesource.com/1413817

pi...@google.com <pi...@google.com> May 18, 2022 05:17PM

Reassigned to sl...@google.com.

Issue 166489398

Description

Bug

Reason

Issue summary

Comments

su...@google.com <su...@google.com> Aug 28, 2020 06:28PM

ap...@google.com <ap...@google.com> #2Sep 2, 2020 10:14PM

pi...@google.com <pi...@google.com> May 18, 2022 05:17PM

Add comment

Issue metadata