Verified
Status Update
No update yet.
Comments
je...@google.com
je...@google.com
This bug means that most input injection will not work if performed on a scrollable element (or more generically, on an element that is clipped). If the element's unclipped and clipped boundaries are the same, input injection should still work. Not that some operations might still work on clipped elements, for example if clipping clips the same amount on all sides and you inject a click in the center of the element.
As a workaround, you can wrap the element on which you want to inject input in a layout (e.g. a Stack) whose unclipped bounds correspond with the clipped bounds of the element. For example:
ScrollableColumn(Modifier.testTag("element")) { /* content */ }
...
onNodeWithTag("element").performGesture { swipeUp() }
becomes
Stack(Modifier.testTag("element")) {
ScrollableColumn { /* content */ }
}
...
onNodeWithTag("element").performGesture { swipeUp() }
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 33c83a3475360da491ae9bd322ca8c8b20f9e570
Author: Jelle Fresen <jellefresen@google.com>
Date: Thu Aug 27 15:39:59 2020
Fix GestureScope position calculations
They must use the clipped bounds, not the unclipped bounds, because
gestures are performed on the visible area.
Fixes: 166589947
Test: Added 2 tests to PositionsTest
Relnote: "Fixed size and position calculations in GestureScope, which
caused amongst others generation of invalid swipe gestures"
Change-Id: Iaf358bea0470bd6f0e907c6bdd901bb95bea0447
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/DraggableTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ZoomableTest.kt
M ui/ui-test/api/current.txt
M ui/ui-test/api/public_plus_experimental_current.txt
M ui/ui-test/api/restricted_current.txt
M ui/ui-test/src/androidAndroidTest/kotlin/androidx/ui/test/gesturescope/PositionsTest.kt
M ui/ui-test/src/androidAndroidTest/kotlin/androidx/ui/test/gesturescope/SendSwipeTest.kt
M ui/ui-test/src/commonMain/kotlin/androidx/ui/test/GestureScope.kt
https://android-review.googlesource.com/1413568
Branch: androidx-master-dev
commit 33c83a3475360da491ae9bd322ca8c8b20f9e570
Author: Jelle Fresen <jellefresen@google.com>
Date: Thu Aug 27 15:39:59 2020
Fix GestureScope position calculations
They must use the clipped bounds, not the unclipped bounds, because
gestures are performed on the visible area.
Fixes: 166589947
Test: Added 2 tests to PositionsTest
Relnote: "Fixed size and position calculations in GestureScope, which
caused amongst others generation of invalid swipe gestures"
Change-Id: Iaf358bea0470bd6f0e907c6bdd901bb95bea0447
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/DraggableTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ZoomableTest.kt
M ui/ui-test/api/current.txt
M ui/ui-test/api/public_plus_experimental_current.txt
M ui/ui-test/api/restricted_current.txt
M ui/ui-test/src/androidAndroidTest/kotlin/androidx/ui/test/gesturescope/PositionsTest.kt
M ui/ui-test/src/androidAndroidTest/kotlin/androidx/ui/test/gesturescope/SendSwipeTest.kt
M ui/ui-test/src/commonMain/kotlin/androidx/ui/test/GestureScope.kt
Description
No description yet.