Custom "layout managers" for LazyColumn/Row [166591700]

Fixed

Feature Request

Status Update

No update yet.

Description

an...@google.com

created issue #1

Aug 27, 2020 11:44AM

We need reusable mechanism to provide custom "layout managers" (LazyLayout?). It will power grids, staggered grids, maybe sticky headers

Comments

an...@google.com <an...@google.com> Jun 18, 2021 03:42PM

Reassigned to po...@google.com.

ap...@google.com <ap...@google.com> #2Sep 3, 2021 07:58PM

On first blush, this doesn't appear to be related to my current changes, as this is an error in the recomopser not the composer. However, the fact it requires an inline function seems suspiciously close.

sp...@gmail.com <sp...@gmail.com> #3Feb 8, 2022 04:34PM

The issue appears to be that, starting in 1.4.3, the composer used in the inlined lambda is the one captured from the parent. This is not the right one when a dialog is being presented as it is the composer for the dialog, not the dialog host.

an...@google.com <an...@google.com> #4Feb 9, 2022 02:29PM

The only change between 1.4.2 and 1.4.3 is https://android-review.googlesource.com/#/q/Ie93edb78b8427e56b4bef15b872a919b8bac0664

Handing this to Andrei to look at as this was his change.

po...@google.com <po...@google.com> Feb 24, 2022 11:31AM

Reassigned to an...@google.com.

ap...@google.com <ap...@google.com> #5Apr 8, 2022 11:19AM

Marked as fixed.

Note to Andrei: After the aosp/2423347, the cross-inline lambda is capturing the $composer parameter from the caller instead of using the $composer parameter passed in to the lambda it was inlined into. This causes changes to be made to the composer that is not currently being used for composition which confused the recomposer.

Issue 166591700