RowScope and ColumnScope should not be objects [166760797]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Aug 29, 2020 02:15AM

As of Compose 1.0.0-alpha01 both RowScope and ColumnScope are declared as object which allows methods inside it to be statically imported which causes a lot of confusion. Here is one such example:

@Composable
fun Example() {
  Box(modifier = Modifier.size(300.dp)) {
    Text("Some text", 
        // This modifier is being imported from RowScope for example and doesn't work here
        modifier = Modifier.gravity(Alignment.Center)
    )
  }
}

Instead these types of scopes should be interfaces to prevent static imports.

Comments

so...@google.com <so...@google.com> Sep 1, 2020 12:20PM

Assigned to po...@google.com.

ap...@google.com <ap...@google.com> #2Sep 11, 2020 11:03AM

Marked as fixed.

Hi,

I also see my text cut off when I set maxLines = 2. Is it the same issue?

  Box(
    modifier =
      Modifier.size(
        width = 108dp,
        height = 34dp,
      ),
    contentAlignment = Alignment.Center,
  ) {
    BasicText(
      text = "text text text",
      maxLines = 2,
      autoSize = AutoSize.StepBased(minFontSize = 1.sp, maxFontSize = 13.sp, stepSize = 0.2.sp),
    )
  }

Issue 166760797

Description

Issue summary

Comments

so...@google.com <so...@google.com> Sep 1, 2020 12:20PM

ap...@google.com <ap...@google.com> #2Sep 11, 2020 11:03AM

Add comment

Issue metadata