RowScope and ColumnScope should not be objects [166760797]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Aug 29, 2020 02:15AM

As of Compose 1.0.0-alpha01 both RowScope and ColumnScope are declared as object which allows methods inside it to be statically imported which causes a lot of confusion. Here is one such example:

@Composable
fun Example() {
  Box(modifier = Modifier.size(300.dp)) {
    Text("Some text", 
        // This modifier is being imported from RowScope for example and doesn't work here
        modifier = Modifier.gravity(Alignment.Center)
    )
  }
}

Instead these types of scopes should be interfaces to prevent static imports.

Comments

so...@google.com <so...@google.com> Sep 1, 2020 12:20PM

Assigned to po...@google.com.

ap...@google.com <ap...@google.com> #2Sep 11, 2020 11:03AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c8deeacd79052e8df6261e2282f17af292f9d9d8
Author: Mihai Popa <popam@google.com>
Date: Mon Sep 07 12:16:36 2020

Prevent static imports of layout scopes' contents

Relnote: We prevented static imports of contents of layout scopes (e.g. alignWithSiblings in RowScope). The explicit scope alternative should be used instead: `with(RowScope) { Modifier.alignWithSiblings(FirstBaseline) }`.
Fixes: 166760797
Test: built and ran
Change-Id: I216be6984d82e0a41432ac5b89f7d6240eef1b9d

M compose/animation/animation/integration-tests/animation-demos/src/main/java/androidx/compose/animation/demos/EnterExitTransitionDemo.kt
M compose/animation/animation/samples/src/main/java/androidx/compose/animation/samples/AnimatedVisibilitySamples.kt
M compose/desktop/desktop/samples/src/jvmMain/kotlin/androidx/compose/desktop/examples/popupexample/AppContent.kt
M compose/foundation/foundation-layout/api/current.txt
M compose/foundation/foundation-layout/api/public_plus_experimental_current.txt
M compose/foundation/foundation-layout/api/restricted_current.txt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/Column.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/Row.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/Stack.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialTextField.kt

https://android-review.googlesource.com/1420054

Issue 166760797

Description

Issue summary

Comments

so...@google.com <so...@google.com> Sep 1, 2020 12:20PM

ap...@google.com <ap...@google.com> #2Sep 11, 2020 11:03AM

Add comment

Issue metadata