Incorrect MonotonicFrameClock in CoroutineContext of composition-derived scopes [166778123]

Fixed

Bug

Status Update

No update yet.

Description

ad...@google.com

created issue #1

Aug 28, 2020 03:58PM

Coroutine scopes derived from a composition using the rememberCoroutineScope() and launchInComposition APIs should have the Recomposer's MonotonicFrameClock in their coroutineContexts. The absence of this causes jank in animations performed using the withFrameNanos API family as ordering of frame operations with regard to the recomposer loop are not guaranteed. This bug was masked by the CompositionCoroutineScope receiver used by launchInComposition implementing the frame clock interface and providing the correct one through that side channel.

Install the correct frame clock into the coroutineContext and remove CompositionCoroutineScope's interface implementation of MonotonicFrameClock.

Comments

ap...@google.com <ap...@google.com> #2Aug 28, 2020 07:14PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 700259f0afe267dfe78b93db932a3cfd827a119d
Author: Sherry Hu <shuanghu@google.com>
Date: Mon May 10 14:23:09 2021

Add transition motion between fold and unfold.

Bug: 186211031
Test: manual
Change-Id: Id60f07311eca2d94ef91dc28ae45823a475160b4

M slidingpanelayout/slidingpanelayout/build.gradle
M slidingpanelayout/slidingpanelayout/src/androidTest/java/androidx/slidingpanelayout/widget/FoldTest.kt
M slidingpanelayout/slidingpanelayout/src/main/java/androidx/slidingpanelayout/widget/SlidingPaneLayout.java

https://android-review.googlesource.com/1702066

Issue 166778123

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Aug 28, 2020 07:14PM

Add comment

Issue metadata