Fragment transition issues that won't happen when FragmentManager.enableNewStateManager(false) is called [167092035]

Fixed

Bug

Status Update

No update yet.

Description

tf...@gmail.com

created issue #1

Aug 31, 2020 12:46PM

Component used: Fragment

Version used: 1.3.0-alpha08

Devices/Android versions reproduced on: Pixel 4 / Android 10

Sample project: https://github.com/tfcporciuncula/broken-transition

Fragment blinking issue video: https://github.com/tfcporciuncula/broken-transition/blob/master/videos/red%20blink.mp4 (you might need to go frame by frame in the video to see the blinking)

Back issue video: https://github.com/tfcporciuncula/broken-transition/blob/master/videos/back%20regular.mp4 (and here's a video with the regular behavior for this)

I have very simple slide transitions defined by myself (exactly like these ones) and I noticed they got a bit broken after I updated everything to the latest version. I decided to call FragmentManager.enableNewStateManager(false) to check if the issues were related to the new state manager, and indeed the issues were gone after that.

The first issue I noticed was that the fragment I'm transitioning to blinks in the very beginning of the transition. I managed to reproduce it in the very simple example I'm linking here, but for some reason the issue seems to happen more frequently on my actual app and not that often in the sample, even though it still happen fairly often. It feels like it's a single frame blink, so it's a little hard to see but it's definitely noticeable when it happens.

There's a second issue I noticed while testing this with a super slow transition duration: when I tap back during the transition from the blue fragment to the red fragment, I end up in a blank screen. If I have the enableNewStateManager(false) call, it simply moves to the end of the transition and transitions back from the blue fragment to the red, certainly a better behavior.

Comments

tf...@gmail.com <tf...@gmail.com> #2Aug 31, 2020 01:34PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

il...@google.com <il...@google.com> Sep 16, 2020 06:31PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #3Sep 30, 2020 08:54PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 0d5272e6e4fe56f09e5246d42c0930bcc50e26fa
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Sep 29 23:38:37 2020

Fix issues caused by interrupting exit effects

When removing a fragment using an exit effect, then reversing the exit
operation (by using the back button) to an enter effect, while exiting
the fragment only ever makes it to AWAITING_EXIT_EFFECTS so the view is
not destroyed. This means that when the fragment attempts to reenter it
does not go through createView() which gets the view ready for effects.

For this case, we need to:

1. Ensure we endViewTransition() on the exiting view since the one we
call in onAnimationEnd() wouldn't be executed until after the enter
aniamtion ended.
2. We need to prepare the entering view to be animated in by setting
its alpha to 0, then same as we should if it had gone through createView

RelNote: "Exiting fragments that have their effects reversed now
correctly cancel and restart with the proper entering effect."
Bug: 167092035
Test: FragmentAnimationTest.popReplaceOperationWithAnimation

Change-Id: I622265e9b4ebb210657aac2a5b97dd47061bfd5c

M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentAnimationTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java

https://android-review.googlesource.com/1442517

il...@google.com <il...@google.com> Oct 27, 2020 11:46PM

Marked as fixed.

ja...@gmail.com <ja...@gmail.com> #4Oct 27, 2020 11:58PM

Any plans soon to release a new fragment beta containing the fix?

il...@google.com <il...@google.com> #5Oct 28, 2020 12:07AM

Re #4 - we're working through our hotlist of issues to confirm that all of them are fixed and only then will be putting out another release. You'd want to use FragmentManager.enableNewStateManager(false) until that point.

Issue 167092035