Allow passing an InteractionState to RadioButton [167164434]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Aug 31, 2020 02:13PM

When using radio buttons it's often useful to be able to be make the button appear pressed when tapping the background or label as well. Currently this can be solved by passing the indication modifier to the radio button but that requires you to duplicate the ripple. Instead you should be able to pass an InteractionState directly to the radio button I think.

Compose version: 1.0.0-alpha01

Comments

cl...@google.com <cl...@google.com> Sep 1, 2020 12:02PM

Assigned to ma...@google.com.

ma...@google.com <ma...@google.com> #2Sep 1, 2020 12:12PM

Project: platform/frameworks/support
Branch: androidx-main

commit 9082f62682f853ad5251a1c79dde9eccba7abdd9
Author: Max Alfonso-Ying <maxying@google.com>
Date: Thu Apr 18 00:34:40 2024

[M2 text field] Apply background to decoration box

...instead of to the BasicTextField, so changing the
backgroundColor will properly change the decoration
box's background color.

Fixes:

b/307694651

Test: added unit tests
Relnote: "Fix backgroundColor not applying to
TextFieldDecorationBox and OutlinedTextFieldDecorationBox.
Decoration boxes now accept a `shape` parameter."
Change-Id: I371c26718597cb36ac537e9412ce476532afb40d

M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/TextFieldDecorationBoxDemos.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/textfield/TextFieldDecorationBoxTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldDefaults.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt

https://android-review.googlesource.com/3046833

lp...@google.com <lp...@google.com> Sep 16, 2020 02:46PM

Reassigned to lp...@google.com.

lp...@google.com <lp...@google.com> Sep 17, 2020 02:33PM

Marked as fixed.

ap...@google.com <ap...@google.com> #3Sep 17, 2020 02:33PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 62eb7deccbe3896c84e04000361bbbc7a69909af
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Wed Sep 16 20:32:07 2020

Exposes InteractionState parameters in stateful Material components, such as Slider and Switch

This allows hoisting the InteractionState above the component, to control how a component appears in different Interactions, or manually setting states for a given component, such as to make a RadioButton appear pressed when a ListItem containing a RadioButton is pressed.

Bug:

b/168025711

Bug:

b/167164434

Test: ./gradlew updateApi
Relnote: "Exposes InteractionState parameters in stateful Material components, to allow hoisting the state and reading / controlling the state."
Change-Id: Iaca5f65f8132a6f2b45d461001fa740d08b6bacb

M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Checkbox.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Menu.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/RadioButton.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Slider.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Switch.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt

https://android-review.googlesource.com/1428672

Issue 167164434