Allow passing an InteractionState to RadioButton [167164434]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Aug 31, 2020 02:13PM

When using radio buttons it's often useful to be able to be make the button appear pressed when tapping the background or label as well. Currently this can be solved by passing the indication modifier to the radio button but that requires you to duplicate the ripple. Instead you should be able to pass an InteractionState directly to the radio button I think.

Compose version: 1.0.0-alpha01

Comments

cl...@google.com <cl...@google.com> Sep 1, 2020 12:02PM

Assigned to ma...@google.com.

ma...@google.com <ma...@google.com> #2Sep 1, 2020 12:12PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020

IconButton / IconToggleButton API scrub

Test: ./gradlew updateApi
Bug:

b/161809385

Bug:

b/161807956

Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96

M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt

https://android-review.googlesource.com/1394868

lp...@google.com <lp...@google.com> Sep 16, 2020 02:46PM

Reassigned to lp...@google.com.

lp...@google.com <lp...@google.com> Sep 17, 2020 02:33PM

Marked as fixed.

ap...@google.com <ap...@google.com> #3Sep 17, 2020 02:33PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 62eb7deccbe3896c84e04000361bbbc7a69909af
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Wed Sep 16 20:32:07 2020

Exposes InteractionState parameters in stateful Material components, such as Slider and Switch

This allows hoisting the InteractionState above the component, to control how a component appears in different Interactions, or manually setting states for a given component, such as to make a RadioButton appear pressed when a ListItem containing a RadioButton is pressed.

Bug:

b/168025711

Bug:

b/167164434

Test: ./gradlew updateApi
Relnote: "Exposes InteractionState parameters in stateful Material components, to allow hoisting the state and reading / controlling the state."
Change-Id: Iaca5f65f8132a6f2b45d461001fa740d08b6bacb

M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Checkbox.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Menu.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/RadioButton.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Slider.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Switch.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt

https://android-review.googlesource.com/1428672

Issue 167164434