stringResource doesn't change on locale change when configuration changes are handled manually [167352819]

Fixed

Bug

Status Update

No update yet.

Description

ra...@gmail.com

created issue #1

Sep 1, 2020 03:25PM

Android Studio Build: 4.2 canary 8
Version of Gradle Plugin: 4.2.0-alpha08
Version of Gradle: 6.6
Version of Java: 1.8
OS: Linux
Version of Compose: 1.0.0-alpha01

Steps to Reproduce:

Use androidx.compose.ui.res.stringResource in an Activity with android:configChanges="locale|layoutDirection"> declared in the manifest
Change the device language to one which has a translation for the string in the previous step
Observe that the old string is displayed instead of the one for the new language

This seems to be because stringResource gets the string from the Context in the ContextAmbient, but ContextAmbient doesn't change when the Configuration changes.

I've been working around this for now with something like

@Composable
fun localizedString(@StringRes id: Int): String {
    val context = ContextAmbient.current
    val resources = remember(ConfigurationAmbient.current) { context.resources }
    return resources.getString(id)
}

... but it would be nice if compose handled this. I also suspect that this affects other @Composables that resolve resource IDs.

Comments

si...@google.com <si...@google.com> Sep 1, 2020 03:49PM

Assigned to an...@google.com.

si...@google.com <si...@google.com> Sep 2, 2020 11:08PM

Reassigned to ha...@google.com.

si...@google.com <si...@google.com> #2Sep 14, 2020 11:55PM

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

ha...@google.com <ha...@google.com> Oct 8, 2020 12:03AM

Accepted by ha...@google.com.

ap...@google.com <ap...@google.com> #3Oct 26, 2020 07:07PM

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

ha...@google.com <ha...@google.com> Oct 26, 2020 08:53PM

Marked as fixed.

Issue 167352819