Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 80c8907809c42e53332740c692b032c5d3279aa8
Author: husaynhakeem <husaynhakeem@google.com>
Date: Thu Sep 03 11:57:35 2020
Fail fast and notify user if image capture destination is invalid
This CL verifies the image save destination is valid and can be written to before triggering the image capture pipeline. This prevents taking a picture if the capture result cannot be saved.
Bug:
Test: ImageSaveLocationValidatorTest.kt
Change-Id: Ic61cda8781d028162ef98ba74d12f0ff872eb211
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
A camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
A camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java
https://android-review.googlesource.com/1419729
https://goto.google.com/android-sha1/80c8907809c42e53332740c692b032c5d3279aa8
Branch: androidx-master-dev
commit 80c8907809c42e53332740c692b032c5d3279aa8
Author: husaynhakeem <husaynhakeem@google.com>
Date: Thu Sep 03 11:57:35 2020
Fail fast and notify user if image capture destination is invalid
This CL verifies the image save destination is valid and can be written to before triggering the image capture pipeline. This prevents taking a picture if the capture result cannot be saved.
Bug:
Test: ImageSaveLocationValidatorTest.kt
Change-Id: Ic61cda8781d028162ef98ba74d12f0ff872eb211
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
A camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
A camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java
hu...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit ee9fa116b553b77b17badd7cac58374c99651753
Author: husaynhakeem <husaynhakeem@google.com>
Date: Fri Sep 11 00:24:35 2020
Fix bug in validating file save destination for image capture
To validate the save destination of image capture when the outputOption contains a file, try opening a write stream to the file. If it succeeds, the file is writable and the image capture save location is valid, otherwise it's invalid.
This validation previously used File.canWrite(), this works correctly for files that are actually created (e.g. using File.createTemp()). When creating a file object with `new File(...)`, the method constantly returns false. This was causing the tests in the rotation test app (uiwidgets/rotations) to fail.
Bug: 167697553
Test: ImageSaveLocationValidatorTest.java + ImageCapture rotation tests
Change-Id: I8c5656fcc5da0c477203b3b5c8bb450be148b323
M camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java
https://android-review.googlesource.com/1425243
https://goto.google.com/android-sha1/ee9fa116b553b77b17badd7cac58374c99651753
Branch: androidx-master-dev
commit ee9fa116b553b77b17badd7cac58374c99651753
Author: husaynhakeem <husaynhakeem@google.com>
Date: Fri Sep 11 00:24:35 2020
Fix bug in validating file save destination for image capture
To validate the save destination of image capture when the outputOption contains a file, try opening a write stream to the file. If it succeeds, the file is writable and the image capture save location is valid, otherwise it's invalid.
This validation previously used File.canWrite(), this works correctly for files that are actually created (e.g. using File.createTemp()). When creating a file object with `new File(...)`, the method constantly returns false. This was causing the tests in the rotation test app (uiwidgets/rotations) to fail.
Bug: 167697553
Test: ImageSaveLocationValidatorTest.java + ImageCapture rotation tests
Change-Id: I8c5656fcc5da0c477203b3b5c8bb450be148b323
M camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java
ap...@google.com
Project: platform/frameworks/support
Branch: snap-temp-L87300000695801067
commit 5b7a369fa062c0593e549e8fe2fc10a06617baa3
Author: husaynhakeem <husaynhakeem@google.com>
Date: Fri Sep 11 00:24:35 2020
Fix bug in validating file save destination for image capture
To validate the save destination of image capture when the outputOption contains a file, try opening a write stream to the file. If it succeeds, the file is writable and the image capture save location is valid, otherwise it's invalid.
This validation previously used File.canWrite(), this works correctly for files that are actually created (e.g. using File.createTemp()). When creating a file object with `new File(...)`, the method constantly returns false. This was causing the tests in the rotation test app (uiwidgets/rotations) to fail.
Bug: 167697553
Test: ImageSaveLocationValidatorTest.java + ImageCapture rotation tests
Change-Id: I8c5656fcc5da0c477203b3b5c8bb450be148b323
(cherry picked from commit ee9fa116b553b77b17badd7cac58374c99651753)
M camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java
https://android-review.googlesource.com/1432092
Branch: snap-temp-L87300000695801067
commit 5b7a369fa062c0593e549e8fe2fc10a06617baa3
Author: husaynhakeem <husaynhakeem@google.com>
Date: Fri Sep 11 00:24:35 2020
Fix bug in validating file save destination for image capture
To validate the save destination of image capture when the outputOption contains a file, try opening a write stream to the file. If it succeeds, the file is writable and the image capture save location is valid, otherwise it's invalid.
This validation previously used File.canWrite(), this works correctly for files that are actually created (e.g. using File.createTemp()). When creating a file object with `new File(...)`, the method constantly returns false. This was causing the tests in the rotation test app (uiwidgets/rotations) to fail.
Bug: 167697553
Test: ImageSaveLocationValidatorTest.java + ImageCapture rotation tests
Change-Id: I8c5656fcc5da0c477203b3b5c8bb450be148b323
(cherry picked from commit ee9fa116b553b77b17badd7cac58374c99651753)
M camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java
ap...@google.com
Project: platform/frameworks/support
Branch: snap-temp-L72800000695805814
commit 240338b47aaa714601dd53aa83f4430d3b950f42
Author: husaynhakeem <husaynhakeem@google.com>
Date: Fri Sep 11 00:24:35 2020
Fix bug in validating file save destination for image capture
To validate the save destination of image capture when the outputOption contains a file, try opening a write stream to the file. If it succeeds, the file is writable and the image capture save location is valid, otherwise it's invalid.
This validation previously used File.canWrite(), this works correctly for files that are actually created (e.g. using File.createTemp()). When creating a file object with `new File(...)`, the method constantly returns false. This was causing the tests in the rotation test app (uiwidgets/rotations) to fail.
Bug: 167697553
Test: ImageSaveLocationValidatorTest.java + ImageCapture rotation tests
Change-Id: I8c5656fcc5da0c477203b3b5c8bb450be148b323
(cherry picked from commit ee9fa116b553b77b17badd7cac58374c99651753)
M camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java
https://android-review.googlesource.com/1432094
Branch: snap-temp-L72800000695805814
commit 240338b47aaa714601dd53aa83f4430d3b950f42
Author: husaynhakeem <husaynhakeem@google.com>
Date: Fri Sep 11 00:24:35 2020
Fix bug in validating file save destination for image capture
To validate the save destination of image capture when the outputOption contains a file, try opening a write stream to the file. If it succeeds, the file is writable and the image capture save location is valid, otherwise it's invalid.
This validation previously used File.canWrite(), this works correctly for files that are actually created (e.g. using File.createTemp()). When creating a file object with `new File(...)`, the method constantly returns false. This was causing the tests in the rotation test app (uiwidgets/rotations) to fail.
Bug: 167697553
Test: ImageSaveLocationValidatorTest.java + ImageCapture rotation tests
Change-Id: I8c5656fcc5da0c477203b3b5c8bb450be148b323
(cherry picked from commit ee9fa116b553b77b17badd7cac58374c99651753)
M camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java
ap...@google.com
Project: platform/frameworks/support
Branch: snap-temp-L56300000695806117
commit 34655560b066fc448da6d1360a39b60c382a3894
Author: husaynhakeem <husaynhakeem@google.com>
Date: Fri Sep 11 00:24:35 2020
Fix bug in validating file save destination for image capture
To validate the save destination of image capture when the outputOption contains a file, try opening a write stream to the file. If it succeeds, the file is writable and the image capture save location is valid, otherwise it's invalid.
This validation previously used File.canWrite(), this works correctly for files that are actually created (e.g. using File.createTemp()). When creating a file object with `new File(...)`, the method constantly returns false. This was causing the tests in the rotation test app (uiwidgets/rotations) to fail.
Bug: 167697553
Test: ImageSaveLocationValidatorTest.java + ImageCapture rotation tests
Change-Id: I8c5656fcc5da0c477203b3b5c8bb450be148b323
(cherry picked from commit ee9fa116b553b77b17badd7cac58374c99651753)
M camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java
https://android-review.googlesource.com/1432097
Branch: snap-temp-L56300000695806117
commit 34655560b066fc448da6d1360a39b60c382a3894
Author: husaynhakeem <husaynhakeem@google.com>
Date: Fri Sep 11 00:24:35 2020
Fix bug in validating file save destination for image capture
To validate the save destination of image capture when the outputOption contains a file, try opening a write stream to the file. If it succeeds, the file is writable and the image capture save location is valid, otherwise it's invalid.
This validation previously used File.canWrite(), this works correctly for files that are actually created (e.g. using File.createTemp()). When creating a file object with `new File(...)`, the method constantly returns false. This was causing the tests in the rotation test app (uiwidgets/rotations) to fail.
Bug: 167697553
Test: ImageSaveLocationValidatorTest.java + ImageCapture rotation tests
Change-Id: I8c5656fcc5da0c477203b3b5c8bb450be148b323
(cherry picked from commit ee9fa116b553b77b17badd7cac58374c99651753)
M camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java
an...@google.com
The following changes were cherrypicked through
Release Track:
Changes: aosp/1425243
ap...@google.com
Project: platform/frameworks/support
Branch: snap-temp-L35100000695851870
commit 05592a19dd8be2804e0c1824ed112153136d26d8
Author: husaynhakeem <husaynhakeem@google.com>
Date: Fri Sep 11 00:24:35 2020
Fix bug in validating file save destination for image capture
To validate the save destination of image capture when the outputOption contains a file, try opening a write stream to the file. If it succeeds, the file is writable and the image capture save location is valid, otherwise it's invalid.
This validation previously used File.canWrite(), this works correctly for files that are actually created (e.g. using File.createTemp()). When creating a file object with `new File(...)`, the method constantly returns false. This was causing the tests in the rotation test app (uiwidgets/rotations) to fail.
Bug: 167697553
Test: ImageSaveLocationValidatorTest.java + ImageCapture rotation tests
Change-Id: I8c5656fcc5da0c477203b3b5c8bb450be148b323
(cherry picked from commit ee9fa116b553b77b17badd7cac58374c99651753)
M camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java
https://android-review.googlesource.com/1430181
Branch: snap-temp-L35100000695851870
commit 05592a19dd8be2804e0c1824ed112153136d26d8
Author: husaynhakeem <husaynhakeem@google.com>
Date: Fri Sep 11 00:24:35 2020
Fix bug in validating file save destination for image capture
To validate the save destination of image capture when the outputOption contains a file, try opening a write stream to the file. If it succeeds, the file is writable and the image capture save location is valid, otherwise it's invalid.
This validation previously used File.canWrite(), this works correctly for files that are actually created (e.g. using File.createTemp()). When creating a file object with `new File(...)`, the method constantly returns false. This was causing the tests in the rotation test app (uiwidgets/rotations) to fail.
Bug: 167697553
Test: ImageSaveLocationValidatorTest.java + ImageCapture rotation tests
Change-Id: I8c5656fcc5da0c477203b3b5c8bb450be148b323
(cherry picked from commit ee9fa116b553b77b17badd7cac58374c99651753)
M camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java
Description
When the user specifies a destination to store the result of an image capture (with the use of
outputFileOptions), theImageCaptureuse case should verify whether this destination is valid before triggering the image capture request to the camera. If the destination is not valid, the operation should fail fast and the user should be notified about it.