Fixed
Status Update
Comments
nj...@google.com <nj...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 9082f62682f853ad5251a1c79dde9eccba7abdd9
Author: Max Alfonso-Ying <maxying@google.com>
Date: Thu Apr 18 00:34:40 2024
[M2 text field] Apply background to decoration box
...instead of to the BasicTextField, so changing the
backgroundColor will properly change the decoration
box's background color.
Fixes: b/307694651
Test: added unit tests
Relnote: "Fix backgroundColor not applying to
TextFieldDecorationBox and OutlinedTextFieldDecorationBox.
Decoration boxes now accept a `shape` parameter."
Change-Id: I371c26718597cb36ac537e9412ce476532afb40d
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/TextFieldDecorationBoxDemos.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/textfield/TextFieldDecorationBoxTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldDefaults.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt
https://android-review.googlesource.com/3046833
Branch: androidx-main
commit 9082f62682f853ad5251a1c79dde9eccba7abdd9
Author: Max Alfonso-Ying <maxying@google.com>
Date: Thu Apr 18 00:34:40 2024
[M2 text field] Apply background to decoration box
...instead of to the BasicTextField, so changing the
backgroundColor will properly change the decoration
box's background color.
Fixes:
Test: added unit tests
Relnote: "Fix backgroundColor not applying to
TextFieldDecorationBox and OutlinedTextFieldDecorationBox.
Decoration boxes now accept a `shape` parameter."
Change-Id: I371c26718597cb36ac537e9412ce476532afb40d
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/TextFieldDecorationBoxDemos.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/textfield/TextFieldDecorationBoxTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldDefaults.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 9b706c4ecad5b5beb4bd22a38d62d987519c64e1
Author: Nader Jawad <njawad@google.com>
Date: Thu Sep 03 19:15:17 2020
Address API council feedback on compose
graphics APIs
Relnote: "--Updated DrawScope APIs with scoped
transformation methods to indicate that the
transformation is only applied within the
callback and removed after the callback is invoked
--Updated clipPath documentation to refer to Path
instead of rounded rectangle
--Fixed spacing in documentation for right parameter
in clipPath
--Renamed DrawScope.drawCanvas to drawIntoCanvas and
removed size parameter
--Renamed dx/dy parameters in inset method to
horizontal and vertical
--Added inset overload that provides the same
inset value to all 4 bounds
--Removed documentation on inset method indicating
that inset would be applied to all 4 sides
--Updated documentation for Rect class
--Updated comments on Rect parameters to match kdoc
style
--Removed Rect.join and Rect.expandToInclude
--Created overload for Rect.translate(offset) and
deprecated Rect.shift"
Updated all compose usages to use non-deprecated
APIs
Fixes: 167737376
Test: Re-ran compose tests and added DrawScope tests
for new inset APIs
Change-Id: If086a1610e1bff12482897852d45cba075dcb4a1
M compose/foundation/foundation-text/src/commonMain/kotlin/androidx/compose/foundation/text/CoreText.kt
M compose/foundation/foundation-text/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Border.kt
M compose/integration-tests/src/main/java/androidx/ui/integration/test/core/SimpleRadioButton2TestCase.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/AppBar.kt
M compose/ui/ui-geometry/api/current.txt
M compose/ui/ui-geometry/api/public_plus_experimental_current.txt
M compose/ui/ui-geometry/api/restricted_current.txt
M compose/ui/ui-geometry/src/commonMain/kotlin/androidx/compose/ui/geometry/Rect.kt
M compose/ui/ui-geometry/src/commonMain/kotlin/androidx/compose/ui/geometry/RoundRect.kt
M compose/ui/ui-geometry/src/test/kotlin/androidx/compose/ui/geometry/RectTest.kt
M compose/ui/ui-graphics/api/current.txt
M compose/ui/ui-graphics/api/public_plus_experimental_current.txt
M compose/ui/ui-graphics/api/restricted_current.txt
M compose/ui/ui-graphics/src/androidAndroidTest/kotlin/androidx/compose/ui/graphics/drawscope/DrawScopeTest.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidPath.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/Path.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/drawscope/DrawScope.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/drawscope/DrawTransform.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/painter/Painter.kt
M compose/ui/ui-graphics/src/desktopMain/kotlin/androidx/compose/ui/graphics/DesktopPath.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/MultiParagraph.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/AndroidAccessibilityTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/node/ViewInterop.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeViewAccessibilityDelegateCompat.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
M ui/ui-test/src/androidMain/kotlin/androidx/ui/test/AndroidAssertions.kt
M ui/ui-test/src/commonMain/kotlin/androidx/ui/test/Actions.kt
https://android-review.googlesource.com/1419739
Branch: androidx-master-dev
commit 9b706c4ecad5b5beb4bd22a38d62d987519c64e1
Author: Nader Jawad <njawad@google.com>
Date: Thu Sep 03 19:15:17 2020
Address API council feedback on compose
graphics APIs
Relnote: "--Updated DrawScope APIs with scoped
transformation methods to indicate that the
transformation is only applied within the
callback and removed after the callback is invoked
--Updated clipPath documentation to refer to Path
instead of rounded rectangle
--Fixed spacing in documentation for right parameter
in clipPath
--Renamed DrawScope.drawCanvas to drawIntoCanvas and
removed size parameter
--Renamed dx/dy parameters in inset method to
horizontal and vertical
--Added inset overload that provides the same
inset value to all 4 bounds
--Removed documentation on inset method indicating
that inset would be applied to all 4 sides
--Updated documentation for Rect class
--Updated comments on Rect parameters to match kdoc
style
--Removed Rect.join and Rect.expandToInclude
--Created overload for Rect.translate(offset) and
deprecated Rect.shift"
Updated all compose usages to use non-deprecated
APIs
Fixes: 167737376
Test: Re-ran compose tests and added DrawScope tests
for new inset APIs
Change-Id: If086a1610e1bff12482897852d45cba075dcb4a1
M compose/foundation/foundation-text/src/commonMain/kotlin/androidx/compose/foundation/text/CoreText.kt
M compose/foundation/foundation-text/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Border.kt
M compose/integration-tests/src/main/java/androidx/ui/integration/test/core/SimpleRadioButton2TestCase.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/AppBar.kt
M compose/ui/ui-geometry/api/current.txt
M compose/ui/ui-geometry/api/public_plus_experimental_current.txt
M compose/ui/ui-geometry/api/restricted_current.txt
M compose/ui/ui-geometry/src/commonMain/kotlin/androidx/compose/ui/geometry/Rect.kt
M compose/ui/ui-geometry/src/commonMain/kotlin/androidx/compose/ui/geometry/RoundRect.kt
M compose/ui/ui-geometry/src/test/kotlin/androidx/compose/ui/geometry/RectTest.kt
M compose/ui/ui-graphics/api/current.txt
M compose/ui/ui-graphics/api/public_plus_experimental_current.txt
M compose/ui/ui-graphics/api/restricted_current.txt
M compose/ui/ui-graphics/src/androidAndroidTest/kotlin/androidx/compose/ui/graphics/drawscope/DrawScopeTest.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidPath.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/Path.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/drawscope/DrawScope.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/drawscope/DrawTransform.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/painter/Painter.kt
M compose/ui/ui-graphics/src/desktopMain/kotlin/androidx/compose/ui/graphics/DesktopPath.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/MultiParagraph.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/AndroidAccessibilityTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/node/ViewInterop.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeViewAccessibilityDelegateCompat.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
M ui/ui-test/src/androidMain/kotlin/androidx/ui/test/AndroidAssertions.kt
M ui/ui-test/src/commonMain/kotlin/androidx/ui/test/Actions.kt
Description
--Update clipPath documentation to refer to Path instead of rounded rectangle
--Update clipRect documentation to have a space between the description for the 'right' parameter
--Update inset docs to indicate that new size/translation is only applied within the provided inline callback
--Update dx/dy parameters in inset method to horizontalInset and verticalInset
--Remove documentation on inset methods indicating that insets are applied to all 4 sides
--Remove documentation on Rect class indicating that Rect can be instantiated via Rect const Offset + const Size
--Remove Rect.join in favor of eexpandToInclude with conditional flag to include empty rectangles
--Create overload for translate(offset) in rect class and deprecate Rect.shift
--Update documentation for bottom property in Rect class