Null pointer exception in BandSelectionHelper [167821507]

Fixed

Bug

Status Update

No update yet.

Description

an...@gmail.com

created issue #1

Sep 4, 2020 11:36PM

Component used: recyclerview-selection Version used: 1.1.0-rc01 Devices/Android versions reproduced on: G1030A/Android 5

Fatal Exception: java.lang.NullPointerException: Attempt to read from field 'int android.graphics.Point.x' on a null object reference
       at androidx.recyclerview.selection.BandSelectionHelper.resizeBand(BandSelectionHelper.java:268)
       at androidx.recyclerview.selection.BandSelectionHelper.onScrolled(BandSelectionHelper.java:329)
       at androidx.recyclerview.selection.BandSelectionHelper$1.onScrolled(BandSelectionHelper.java:102)
       at androidx.recyclerview.widget.RecyclerView.dispatchOnScrolled(RecyclerView.java:5173)
       at androidx.recyclerview.widget.RecyclerView.dispatchLayoutStep3(RecyclerView.java:4231)
       at androidx.recyclerview.widget.RecyclerView.dispatchLayout(RecyclerView.java:3862)
       at androidx.recyclerview.widget.RecyclerView.onLayout(RecyclerView.java:4404)
       at android.view.View.layout(View.java:15671)
       at android.view.ViewGroup.layout(ViewGroup.java:5038)
       at androidx.swiperefreshlayout.widget.SwipeRefreshLayout.onLayout(SwipeRefreshLayout.java:689)
       at android.view.View.layout(View.java:15671)
       at android.view.ViewGroup.layout(ViewGroup.java:5038)
       at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1703)
       at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1557)
       at android.widget.LinearLayout.onLayout(LinearLayout.java:1466)
       at android.view.View.layout(View.java:15671)
       at android.view.ViewGroup.layout(ViewGroup.java:5038)
       at androidx.coordinatorlayout.widget.CoordinatorLayout.layoutChild(CoordinatorLayout.java:1213)
       at androidx.coordinatorlayout.widget.CoordinatorLayout.onLayoutChild(CoordinatorLayout.java:899)
       at androidx.coordinatorlayout.widget.CoordinatorLayout.onLayout(CoordinatorLayout.java:919)
       at android.view.View.layout(View.java:15671)
       at android.view.ViewGroup.layout(ViewGroup.java:5038)
       at android.widget.FrameLayout.layoutChildren(FrameLayout.java:579)
       at android.widget.FrameLayout.onLayout(FrameLayout.java:514)
       at android.view.View.layout(View.java:15671)
       at android.view.ViewGroup.layout(ViewGroup.java:5038)
       at android.widget.FrameLayout.layoutChildren(FrameLayout.java:579)
       at android.widget.FrameLayout.onLayout(FrameLayout.java:514)
       at android.view.View.layout(View.java:15671)
       at android.view.ViewGroup.layout(ViewGroup.java:5038)
       at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1703)
       at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1557)
       at android.widget.LinearLayout.onLayout(LinearLayout.java:1466)
       at android.view.View.layout(View.java:15671)
       at android.view.ViewGroup.layout(ViewGroup.java:5038)
       at android.widget.FrameLayout.layoutChildren(FrameLayout.java:579)
       at android.widget.FrameLayout.onLayout(FrameLayout.java:514)
       at android.view.View.layout(View.java:15671)
       at android.view.ViewGroup.layout(ViewGroup.java:5038)
       at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1703)
       at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1557)
       at android.widget.LinearLayout.onLayout(LinearLayout.java:1466)
       at android.view.View.layout(View.java:15671)
       at android.view.ViewGroup.layout(ViewGroup.java:5038)
       at android.widget.FrameLayout.layoutChildren(FrameLayout.java:579)
       at android.widget.FrameLayout.onLayout(FrameLayout.java:514)
       at android.view.View.layout(View.java:15671)
       at android.view.ViewGroup.layout(ViewGroup.java:5038)
       at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1703)
       at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1557)
       at android.widget.LinearLayout.onLayout(LinearLayout.java:1466)
       at android.view.View.layout(View.java:15671)
       at android.view.ViewGroup.layout(ViewGroup.java:5038)
       at android.widget.FrameLayout.layoutChildren(FrameLayout.java:579)
       at android.widget.FrameLayout.onLayout(FrameLayout.java:514)
       at android.view.View.layout(View.java:15671)
       at android.view.ViewGroup.layout(ViewGroup.java:5038)
       at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:2086)
       at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:1843)
       at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1061)
       at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:5885)
       at android.view.Choreographer$CallbackRecord.run(Choreographer.java:767)
       at android.view.Choreographer.doCallbacks(Choreographer.java:580)
       at android.view.Choreographer.doFrame(Choreographer.java:550)
       at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:753)
       at android.os.Handler.handleCallback(Handler.java:739)
       at android.os.Handler.dispatchMessage(Handler.java:95)
       at android.os.Looper.loop(Looper.java:135)
       at android.app.ActivityThread.main(ActivityThread.java:5258)
       at java.lang.reflect.Method.invoke(Method.java)
       at java.lang.reflect.Method.invoke(Method.java:372)
       at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)

Comments

an...@gmail.com <an...@gmail.com> #2Sep 4, 2020 11:37PM

This isn't fixed in alpha 6 :(. It's easily reproducible by starting a drag with one finger and then tapping somewhere else (think back button) which calls clearSelection().

sh...@google.com <sh...@google.com> Sep 10, 2020 12:26AM

Reassigned to sm...@google.com.

sm...@google.com <sm...@google.com> #3Sep 10, 2020 02:23AM

Comment from

https://b.corp.google.com/issues/128054552#comment9

ap...@google.com <ap...@google.com> #4Sep 11, 2020 05:52PM

Fix is in the works. Until then, a workaround is to avoid calling SelectionTracker#clearSelection while a gesture or mouse-band selection operation is in progress. Such a condition is likely not reflective of user intent (given the ongoing stream of selection operation), but reflective of a stray tap.

State can be monitored using OperationMonitor:

https://developer.android.com/reference/androidx/recyclerview/selection/OperationMonitor.OnChangeListener.html

sm...@google.com <sm...@google.com> #5Sep 11, 2020 05:57PM

BTW, working on a fix for this (general improvement to state management). My unassigning this issue from me should not be construed as lack of attention to the matter. I just manage issues by hotlist (rather than ownership).

ap...@google.com <ap...@google.com> #6Sep 16, 2020 06:34PM

Rolling all state-related crash reports up into a single tracking bug.

ap...@google.com <ap...@google.com> #7Sep 16, 2020 06:37PM

Fixed in upcoming beta01 release.

ap...@google.com <ap...@google.com> #8Sep 16, 2020 06:55PM

Project: platform/frameworks/support
Branch: snap-temp-L17300000693927416

commit 3d8da646b7b9b3138e3793a946611f88085755d7
Author: Steve McKay <smckay@google.com>
Date: Wed Sep 09 18:59:44 2020

Handle unexpected scrolls gracefull.

Bug: 167821507
Test: Added new unit test coverage.
Change-Id: I013a5d3bfc2675caaf9ba51e056abf2c1f9c99d2
(cherry picked from commit d209da0255ea98831da70651ce7d8da682590952)

M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/BandSelectionHelperTest.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/BandSelectionHelper.java

https://android-review.googlesource.com/1429132

an...@google.com <an...@google.com> #9Sep 16, 2020 06:55PM

The following changes were cherrypicked through Coastguard
Release Track: 4819333773066240
Changes: aosp/1428853

sm...@google.com <sm...@google.com> #10Sep 16, 2020 08:56PM

Marked as fixed.

Turns out I forgot to schedule the rc03 release. Missed the 9/16 boat. Scheduled for 9/30 including this fix.