Fixed
Status Update
Comments
an...@gmail.com <an...@gmail.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
sh...@google.com <sh...@google.com>
sm...@google.com <sm...@google.com> #3
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically ( b/140759491 ).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
sm...@google.com <sm...@google.com> #5
Fix is available in tip of tree. I'll keep this issue open to track inclusion in a stable release.
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: snap-temp-L69500000693898025
commit cf387258fbf0b4b55e622539d1a77eb4d92288dc
Author: Steve McKay <smckay@google.com>
Date: Wed Sep 09 18:59:44 2020
Handle unexpected scrolls gracefull.
Bug: 167821507
Test: Added new unit test coverage.
Change-Id: I013a5d3bfc2675caaf9ba51e056abf2c1f9c99d2
(cherry picked from commit d209da0255ea98831da70651ce7d8da682590952)
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/BandSelectionHelperTest.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/BandSelectionHelper.java
https://android-review.googlesource.com/1429069
Branch: snap-temp-L69500000693898025
commit cf387258fbf0b4b55e622539d1a77eb4d92288dc
Author: Steve McKay <smckay@google.com>
Date: Wed Sep 09 18:59:44 2020
Handle unexpected scrolls gracefull.
Bug: 167821507
Test: Added new unit test coverage.
Change-Id: I013a5d3bfc2675caaf9ba51e056abf2c1f9c99d2
(cherry picked from commit d209da0255ea98831da70651ce7d8da682590952)
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/BandSelectionHelperTest.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/BandSelectionHelper.java
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: snap-temp-L90000000693899338
commit ce1403eb07be6261183e2459af6ffdc2412eef71
Author: Steve McKay <smckay@google.com>
Date: Wed Sep 09 18:59:44 2020
Handle unexpected scrolls gracefull.
Bug: 167821507
Test: Added new unit test coverage.
Change-Id: I013a5d3bfc2675caaf9ba51e056abf2c1f9c99d2
(cherry picked from commit d209da0255ea98831da70651ce7d8da682590952)
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/BandSelectionHelperTest.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/BandSelectionHelper.java
https://android-review.googlesource.com/1429070
Branch: snap-temp-L90000000693899338
commit ce1403eb07be6261183e2459af6ffdc2412eef71
Author: Steve McKay <smckay@google.com>
Date: Wed Sep 09 18:59:44 2020
Handle unexpected scrolls gracefull.
Bug: 167821507
Test: Added new unit test coverage.
Change-Id: I013a5d3bfc2675caaf9ba51e056abf2c1f9c99d2
(cherry picked from commit d209da0255ea98831da70651ce7d8da682590952)
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/BandSelectionHelperTest.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/BandSelectionHelper.java
ap...@google.com <ap...@google.com> #8
Project: platform/frameworks/support
Branch: snap-temp-L17300000693927416
commit 3d8da646b7b9b3138e3793a946611f88085755d7
Author: Steve McKay <smckay@google.com>
Date: Wed Sep 09 18:59:44 2020
Handle unexpected scrolls gracefull.
Bug: 167821507
Test: Added new unit test coverage.
Change-Id: I013a5d3bfc2675caaf9ba51e056abf2c1f9c99d2
(cherry picked from commit d209da0255ea98831da70651ce7d8da682590952)
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/BandSelectionHelperTest.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/BandSelectionHelper.java
https://android-review.googlesource.com/1429132
Branch: snap-temp-L17300000693927416
commit 3d8da646b7b9b3138e3793a946611f88085755d7
Author: Steve McKay <smckay@google.com>
Date: Wed Sep 09 18:59:44 2020
Handle unexpected scrolls gracefull.
Bug: 167821507
Test: Added new unit test coverage.
Change-Id: I013a5d3bfc2675caaf9ba51e056abf2c1f9c99d2
(cherry picked from commit d209da0255ea98831da70651ce7d8da682590952)
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/BandSelectionHelperTest.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/BandSelectionHelper.java
an...@google.com <an...@google.com> #9
The following changes were cherrypicked through
Release Track:
Changes: aosp/1428853
sm...@google.com <sm...@google.com> #10
Turns out I forgot to schedule the rc03 release. Missed the 9/16 boat. Scheduled for 9/30 including this fix.
Description
Component used: recyclerview-selection Version used: 1.1.0-rc01 Devices/Android versions reproduced on: G1030A/Android 5