Jaggy LazyColumnFor scroll when clickable modifier is used [167972292]

Fixed

Bug

Status Update

No update yet.

Description

al...@gmail.com

created issue #1

Sep 7, 2020 06:39PM

Android Studio Build:
Android Studio 4.2 Canary 9
Build #AI-202.6397.94.42.6795674, built on August 28, 2020
Runtime version: 11.0.7+10-b765.53 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
macOS 10.15.6
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 12

Version of Gradle Plugin:
'com.android.tools.build:gradle:4.2.0-alpha09'

compose_version = '1.0.0-alpha02'
kotlin_version = "1.4.0"

Version of Gradle:
distributionUrl=https\://

services.gradle.org/distributions/gradle-6.6-rc-6-bin.zip

Steps to Reproduce:

number of items in list: 200
code:

LazyColumnFor(items = entries) {
Text(
text = it.word,
modifier = Modifier.clickable(indication = null, onClick = {
selectWordAction(it.word)
})
)
}

the code above was embedded as content to Scaffold.

Comments

an...@google.com <an...@google.com> Sep 8, 2020 08:41AM

Assigned to an...@google.com.

an...@google.com <an...@google.com> #2Sep 8, 2020 04:09PM

Project: platform/frameworks/support
Branch: androidx-main

commit 822b94312ab0e71054dcf8c007d4d8b6ba61db98
Author: Clara Fok <clarafok@google.com>
Date: Wed Dec 06 16:09:13 2023

Refactor PagingDataDiffer PageEvent processing

Streamline the process in preparation for upcoming refactors

Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew paging:paging-common:allTest
Bug: 315214786
Change-Id: I809a5197633e9d7167388160509bec00566d7417

M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagePresenter.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataDiffer.kt

https://android-review.googlesource.com/2871509

al...@gmail.com <al...@gmail.com> #3Sep 8, 2020 06:20PM

Project: platform/frameworks/support
Branch: androidx-main

commit fb741839c9be2e2a0a9e023bbba3c0cbac3c9ebb
Author: Clara Fok <clarafok@google.com>
Date: Wed Dec 06 16:22:46 2023

Rename PagePresenter to PageStore

PageStore will be refactored to only process and store loaded data.

Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew paging:paging-common:allTest
Bug: 315214786
Change-Id: Ic3502d2a541e02355d65cc5154025a0301a50ec5

M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageStore.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataDiffer.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageFetcherSnapshotStateTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageStoreTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/ProcessPageEventCallbackCapture.kt

https://android-review.googlesource.com/2871510

an...@google.com <an...@google.com> #4Sep 8, 2020 07:01PM

Project: platform/frameworks/support
Branch: androidx-main

commit 3621927b29ae21d513ea12dc171bf795397b6a0a
Author: Clara Fok <clarafok@google.com>
Date: Fri Dec 08 14:19:41 2023

Rename PagingDataDiffer to PagingDataPresenter

Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew paging:paging-common:allTest
Test: ./gradlew paging:paging-compose:cC
Bug: 315214786
Change-Id: I9e0c98ef8508c267c2d02ff64a40d698f9f10bb3

M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PageFetcherTest.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageEvent.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageStore.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataPresenter.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/ViewportHint.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageEventTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PagingDataDifferTest.kt
M paging/paging-compose/src/commonMain/kotlin/androidx/paging/compose/LazyPagingItems.kt
M paging/paging-guava/src/test/java/androidx/paging/ListenableFuturePagingDataTest.kt
M paging/paging-runtime/src/main/java/androidx/paging/AsyncPagingDataDiffer.kt
M paging/paging-rxjava2/src/test/java/androidx/paging/rxjava2/RxPagingDataTest.kt
M paging/paging-rxjava3/src/test/java/androidx/paging/rxjava3/RxPagingDataTest.kt
M paging/paging-testing/src/commonMain/kotlin/androidx/paging/testing/LoadErrorHandler.kt
M paging/paging-testing/src/commonMain/kotlin/androidx/paging/testing/PagerFlowSnapshot.kt
M paging/paging-testing/src/commonMain/kotlin/androidx/paging/testing/SnapshotLoader.kt
M testutils/testutils-paging/src/commonMain/kotlin/androidx/paging/TestPagingDataPresenter.kt

https://android-review.googlesource.com/2871511

al...@gmail.com <al...@gmail.com> #5Sep 8, 2020 07:28PM

Project: platform/frameworks/support
Branch: androidx-main

commit c7505aeb858ee828b9cb386f9923b576eb5cd740
Author: Clara Fok <clarafok@google.com>
Date: Tue Dec 12 16:05:24 2023

Refactor event processing for Append and Prepend

First CL to move DifferCallback duties for Append/Prepend PageEvents out of PagingDataPresenter.

AsyncPagingDataDiffer which implements PagingDataPresenter overrides presentPagingDataEvent method to handle PageEvents for Append and Prepend, which includes calculating callback states and invoking RecyclerView's ListUpdateCallback.

Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew paging:paging-common:allTest
Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew paging:paging-common:jvmTest
Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew paging:paging-common:cC
Test: ./gradlew paging:paging-runtime:cC
Test: ./gradlew paging:paging-compose:cC
Bug: 315214786
Change-Id: Ibc544339c04c1426930e355da4ce647d9d7fdeba

M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/ContiguousPagedList.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/PagedList.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/PagedStorage.jvm.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/NullPaddedList.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageStore.kt
A paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataEvent.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataPresenter.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageFetcherSnapshotStateTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageStoreTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PagingDataPresenterTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/ContiguousPagedListTest.kt
M paging/paging-compose/src/commonMain/kotlin/androidx/paging/compose/LazyPagingItems.kt
M paging/paging-runtime/src/androidTest/java/androidx/paging/AsyncPagingDataDifferTest.kt
M paging/paging-runtime/src/androidTest/java/androidx/paging/NullPaddedListDiffHelperTest.kt
M paging/paging-runtime/src/androidTest/java/androidx/paging/NullPaddedListDiffWithRecyclerViewTest.kt
M paging/paging-runtime/src/main/java/androidx/paging/AsyncPagingDataDiffer.kt
M paging/paging-runtime/src/main/java/androidx/paging/NullPaddedListDiffHelper.kt
M paging/paging-testing/src/commonMain/kotlin/androidx/paging/testing/PagerFlowSnapshot.kt
M testutils/testutils-paging/src/commonMain/kotlin/androidx/paging/TestPagingDataPresenter.kt

https://android-review.googlesource.com/2871512

ap...@google.com <ap...@google.com> #6Sep 23, 2020 11:17AM

Project: platform/frameworks/support
Branch: androidx-main

commit 949e051393841ca6c132098efaf6de16c320d7fc
Author: Clara Fok <clarafok@google.com>
Date: Wed Dec 20 13:57:23 2023

Remove transform lastAccessedIndex after refresh

Transform lastAccessedIndex fulfills two roles - trigger prefetch and trigger load if new list is empty.

We still need to trigger new loads if refreshed page is empty, so we will still send an intial hint on empty refresh. However, we can rely on UI accessing items to update lastAccessedIndex. This delays prefetch by a frame but it is preferable over Refreshes requiring UI to return a transformed index.

Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew paging:paging-common:allTest
Bug: 315214786
Change-Id: I97ffed3e0f63a4551bc1196349157d2c30e8408b

M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataPresenter.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PagingDataPresenterTest.kt
M paging/paging-compose/src/commonMain/kotlin/androidx/paging/compose/LazyPagingItems.kt
M paging/paging-runtime/src/androidTest/java/androidx/paging/AsyncPagingDataDifferTest.kt
M paging/paging-runtime/src/main/java/androidx/paging/AsyncPagingDataDiffer.kt
M paging/paging-testing/src/commonMain/kotlin/androidx/paging/testing/PagerFlowSnapshot.kt
M paging/paging-testing/src/commonMain/kotlin/androidx/paging/testing/SnapshotLoader.kt
M paging/paging-testing/src/commonTest/kotlin/androidx/paging/testing/PagerFlowSnapshotTest.kt
M testutils/testutils-paging/src/commonMain/kotlin/androidx/paging/TestPagingDataPresenter.kt

https://android-review.googlesource.com/2886314

ap...@google.com <ap...@google.com> #7Oct 6, 2020 12:21PM

Project: platform/frameworks/support
Branch: androidx-main

commit 8f41702e894c758cf7833e6841acf167d0cb8013
Author: Clara Fok <clarafok@google.com>
Date: Thu Dec 21 10:24:38 2023

Refactor event processing for Refresh

Upon refresh, PagingDataPresenter now sends a PagingDataEvent.Refresh to the front end. paging-runtime, paging-compose, and paging-testing refactored to handle this new type of refresh events.

Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew paging:paging-common:allTest
Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew paging:paging-common:jvmTest
Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew paging:paging-common:cC
Test: ./gradlew paging:paging-runtime:cC
Test: ./gradlew paging:paging-compose:cC
Test: ./gradlew paging:paging-testing:cC
Bug: 315214786
Change-Id: I71d8caeb0819b5a0a3d6a0159ace399a77972c1f

M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/PagedStorage.jvm.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/NullPaddedList.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageStore.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataEvent.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataPresenter.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PagingDataPresenterTest.kt
M paging/paging-compose/src/commonMain/kotlin/androidx/paging/compose/LazyPagingItems.kt
M paging/paging-runtime/src/androidTest/java/androidx/paging/NullPaddedListDiffHelperTest.kt
M paging/paging-runtime/src/androidTest/java/androidx/paging/NullPaddedListDiffWithRecyclerViewTest.kt
M paging/paging-runtime/src/main/java/androidx/paging/AsyncPagingDataDiffer.kt
M paging/paging-runtime/src/main/java/androidx/paging/NullPaddedListDiffHelper.kt
M paging/paging-testing/src/commonMain/kotlin/androidx/paging/testing/PagerFlowSnapshot.kt
M testutils/testutils-paging/src/commonMain/kotlin/androidx/paging/TestPagingDataPresenter.kt

https://android-review.googlesource.com/2889226

an...@google.com <an...@google.com> #8Oct 7, 2020 02:08PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit ac036c36ad2263f33694046c1a2ba4b85957547a
Author: Clara Fok <clarafok@google.com>
Date: Wed Jan 03 14:18:09 2024

Refactor LoadStateUpdates for Drop Events

LoadStateUpdate from Drop events are now sent from PagingDataPresenter instead of sent to the callback passed to PageStore.

Removed obselete LoadState assertions in PageStoreTest because state updates are now separate from PageStore. Existing tests in PagingDataDifferTest asserts that drop events emit the correct LoadStateUpdates.

Also removed redundant dispatchLoadState helper function so that loadstates are now dispatched directly with MutableCombinedLoadStateCollection set() methods.

Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew paging:paging-common:allTest
Bug: 315214786
Change-Id: I3d62b14b48c572b215309514856dd5478b36e66b

M paging/paging-common/src/commonMain/kotlin/androidx/paging/MutableCombinedLoadStateCollection.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageStore.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataPresenter.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageStoreTest.kt

https://android-review.googlesource.com/2895998