Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 04f29e72e1e25f85e750e237e1e6ac02b24392d1
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Wed Sep 09 12:20:32 2020
Adds InteractionState parameters to Tab and BottomNavigationItem
Also adds screenshot tests for these components in different states / colors.
Bug: b/168025711
Test: BottomNavigationScreenshotTest
Test: TabScreenshotTest
Relnote: "Adds InteractionState parameter to BottomNavigationItem and Tab, allowing hoisting this state and adjusting how the component appears in different states."
Change-Id: Ia3e9ee1699a7d6eda38f4e62ce5a11d4ef616652
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
A compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationScreenshotTest.kt
A compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/TabScreenshotTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomNavigation.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Tab.kt
https://android-review.googlesource.com/1423129
Branch: androidx-master-dev
commit 04f29e72e1e25f85e750e237e1e6ac02b24392d1
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Wed Sep 09 12:20:32 2020
Adds InteractionState parameters to Tab and BottomNavigationItem
Also adds screenshot tests for these components in different states / colors.
Bug:
Test: BottomNavigationScreenshotTest
Test: TabScreenshotTest
Relnote: "Adds InteractionState parameter to BottomNavigationItem and Tab, allowing hoisting this state and adjusting how the component appears in different states."
Change-Id: Ia3e9ee1699a7d6eda38f4e62ce5a11d4ef616652
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
A compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationScreenshotTest.kt
A compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/TabScreenshotTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomNavigation.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Tab.kt
lp...@google.com <lp...@google.com>
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 62eb7deccbe3896c84e04000361bbbc7a69909af
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Wed Sep 16 20:32:07 2020
Exposes InteractionState parameters in stateful Material components, such as Slider and Switch
This allows hoisting the InteractionState above the component, to control how a component appears in different Interactions, or manually setting states for a given component, such as to make a RadioButton appear pressed when a ListItem containing a RadioButton is pressed.
Bug: b/168025711
Bug: b/167164434
Test: ./gradlew updateApi
Relnote: "Exposes InteractionState parameters in stateful Material components, to allow hoisting the state and reading / controlling the state."
Change-Id: Iaca5f65f8132a6f2b45d461001fa740d08b6bacb
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Checkbox.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Menu.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/RadioButton.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Slider.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Switch.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt
https://android-review.googlesource.com/1428672
Branch: androidx-master-dev
commit 62eb7deccbe3896c84e04000361bbbc7a69909af
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Wed Sep 16 20:32:07 2020
Exposes InteractionState parameters in stateful Material components, such as Slider and Switch
This allows hoisting the InteractionState above the component, to control how a component appears in different Interactions, or manually setting states for a given component, such as to make a RadioButton appear pressed when a ListItem containing a RadioButton is pressed.
Bug:
Bug:
Test: ./gradlew updateApi
Relnote: "Exposes InteractionState parameters in stateful Material components, to allow hoisting the state and reading / controlling the state."
Change-Id: Iaca5f65f8132a6f2b45d461001fa740d08b6bacb
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Checkbox.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Menu.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/RadioButton.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Slider.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Switch.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt
Description
Adding the ability to hoist InteractionState in all our components enables a few powerful usecases, including:
RadioButton
looked pressed as well