PlacementScope should have parentHeight [168295623]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Sep 12, 2020 03:24AM

PlacementScope already has a parentWidth which is convenient but it does not have a parentHeight. For consistency it should probably have both or neither. I would prefer both as it would allow for something like this:

layout(
  width = placeables.sumBy { it.width },
  height = placeables.maxOf { it.height }
) { 
  // parentWidth is the sum
  // parentHeight is the max
}

Comments

cl...@google.com <cl...@google.com> Sep 14, 2020 09:27AM

Assigned to po...@google.com.

po...@google.com <po...@google.com> #2Sep 15, 2020 02:15PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

ap...@google.com <ap...@google.com> #3Sep 17, 2020 02:27PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

[Deleted User] <[Deleted User]> #4Oct 9, 2020 03:48PM

deleted

po...@google.com <po...@google.com> #5Oct 9, 2020 04:24PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

[Deleted User] <[Deleted User]> #6Oct 9, 2020 04:27PM

Hmm. I see that as completely valid though. You might want to place it in the center but offset X a number of DP.

But I understand there might be other complexities. I was just surprised there was no way to write such a modifier today.

Issue 168295623