Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 87b3f5e2b28698e8c6820b2a50dbe7a825471aa7
Author: Matvei Malkov <malkov@google.com>
Date: Thu Oct 01 14:41:59 2020
Clean up Scaffold states
* make them @Stable where possible
* properly remember SnackbarState
* move drawerGestureDisabled to Scaffold param for consistency (and also to allow for `gesturesEnabled = scaffoldState.drawerState.isOpen` usecase)
RelNote: all scaffold states marked as @Stable. drawerGesturesEnabled in ScaffoldState moved to Scaffold itself.
Fixes: 168297016
Fixes: 168192218
Test: fixed accordingly
Change-Id: I36645f82bea09908d0045593447f9b684a605fae
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ScaffoldTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BackdropScaffold.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Drawer.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Scaffold.kt
https://android-review.googlesource.com/1444235
Branch: androidx-master-dev
commit 87b3f5e2b28698e8c6820b2a50dbe7a825471aa7
Author: Matvei Malkov <malkov@google.com>
Date: Thu Oct 01 14:41:59 2020
Clean up Scaffold states
* make them @Stable where possible
* properly remember SnackbarState
* move drawerGestureDisabled to Scaffold param for consistency (and also to allow for `gesturesEnabled = scaffoldState.drawerState.isOpen` usecase)
RelNote: all scaffold states marked as @Stable. drawerGesturesEnabled in ScaffoldState moved to Scaffold itself.
Fixes: 168297016
Fixes: 168192218
Test: fixed accordingly
Change-Id: I36645f82bea09908d0045593447f9b684a605fae
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ScaffoldTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BackdropScaffold.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Drawer.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Scaffold.kt
Description
WE don't memorize it and it works thanks to function skipping. We should still memorize SnackbarHostState in rememberScaffoldState.